Repository navigation
Conversation
…55336) ### Rationale for this change Workaround to install clang-22 no longer relevant, breaks CI ### What changes are included in this PR? Remove it ### Are these changes tested? Will run CI ### Are there any user-facing changes? ### Was AI used for this PR? In accordance to the [AI generation guidelines](https://arrow.apache.org/docs/dev/developers/overview.html#ai-generated-code), please disclose below whether and how AI was used in this PR. **PR code and description written by:** - [x] Human - [x] AI **Reviewed before submission by:** - [x] Human - [x] AI - [ ] Not reviewed * GitHub Issue: #55332 Lead-authored-by: Nic Crane <thisisnic@gmail.com> Co-authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
…r hard-codes a cran.rstudio.com URL for Rtools40 that now 404s (#55378) ### Rationale for this change Nightly builds failing due to a change in RTools URL and problem with job ### What changes are included in this PR? Don't pass in rtools version, as this can be inferred anyway ### Are these changes tested? No ### Are there any user-facing changes? No **PR code and description written by:** - [ ] Human - [x] AI **Reviewed before submission by:** - [x] Human - [x] AI - [ ] Not reviewed * GitHub Issue: #55377 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
### Rationale for this change Make sure we can build on CRAN. ### What changes are included in this PR? A test for offline installations of the R package ### Are these changes tested? So far, all tests! ### Are there any user-facing changes? No ### Was AI used for this PR? In accordance to the [AI generation guidelines](https://arrow.apache.org/docs/dev/developers/overview.html#ai-generated-code), please disclose below whether and how AI was used in this PR. **PR code and description written by:** - [x] Human - [ ] AI **Reviewed before submission by:** - [x] Human - [x] AI - [ ] Not reviewed * GitHub Issue: #55454 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com> (cherry picked from commit 4985261)
…e, biggest tarball) (#55491) ### Rationale for this change Vendor (and trim) C++ dependencies for offline builds that would allow us to build Parquet even when CMake cannot reach the internet. This is an R-package-only change, but in doing so can't trim quite as much (specifically building thrift without boost). The resulting tarball is larger than strictly necessary (~13.1 MB). Resolves #55478 ### What changes are included in this PR? Scripts for vendoring and trimming dependencies, tests ### Are these changes tested? Yes ### Are there any user-facing changes? More full-feature arrow builds ### Was AI used for this PR? In accordance to the [AI generation guidelines](https://arrow.apache.org/docs/dev/developers/overview.html#ai-generated-code), please disclose below whether and how AI was used in this PR. **PR code and description written by:** - [x] Human - [ ] AI **Reviewed before submission by:** - [x] Human - [x] AI - [ ] Not reviewed * GitHub Issue: #55478 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com> (cherry picked from commit 931b9cc)
jonkeane
requested review from
AlenkaF,
HuaHuaY,
assignUser,
kevingurney,
kou,
pitrou,
raulcd,
rok,
sgilmore10,
thisisnic and
wgtmac
as code owners
November 19, 2026 14:42
Member
Author
|
@github-actions crossbow submit --group r |
|
Revision: 053e013 Submitted crossbow builds: ursacomputing/crossbow @ actions-3925c227c1 |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved regressions silently disable content-defined chunking for public-factory callers and block valid R source installations and offline builds using local dependency archives.
2 open issues
1 file not reviewed
r/man/acero.Rd: Generated file
What changed in this PR
Prepares the R 26.0.1.1 CRAN verification package on the Arrow 26.0.1 release baseline, following checklist #55680. The PR remains marked do not merge.
Changes:
- Vendors trimmed dependency sources for more capable offline R builds, with checksum handling, documentation, and verification.
- Includes C++ fixes for Parquet chunking and encryption, IPC validation, compute edge cases, and build compatibility.
- Updates release metadata, binary checksums, packaging, and CI configuration.
| File | Description |
|---|---|
| ruby/red-parquet/lib/parquet/version.rb | Sets Parquet gem version to 26.0.1. |
| ruby/red-gandiva/lib/gandiva/version.rb | Sets Gandiva gem version to 26.0.1. |
| ruby/red-arrow/lib/arrow/version.rb | Sets Arrow gem version to 26.0.1. |
| ruby/red-arrow-format/lib/arrow-format/version.rb | Sets format gem version to 26.0.1. |
| ruby/red-arrow-flight/lib/arrow-flight/version.rb | Sets Flight gem version to 26.0.1. |
| ruby/red-arrow-flight-sql/lib/arrow-flight-sql/version.rb | Sets Flight SQL gem version to 26.0.1. |
| ruby/red-arrow-dataset/lib/arrow-dataset/version.rb | Sets Dataset gem version to 26.0.1. |
| ruby/red-arrow-cuda/lib/arrow-cuda/version.rb | Sets CUDA gem version to 26.0.1. |
| r/vignettes/install.Rmd | Documents vendored dependencies and opt-out troubleshooting. |
| r/tools/vendor_dependencies.sh | Downloads, trims, and records dependency archives. |
| r/tools/trim/boost.sh | Retains the Boost subset needed by R builds. |
| r/tools/test-nixlibs.R | Tests vendored dependency selection and configuration. |
| r/tools/nixlibs.R | Integrates vendored sources into libarrow builds. |
| r/tools/checksums/r-libarrow-windows-x86_64-26.0.1.zip.sha512 | Adds Windows binary checksum. |
| r/tools/checksums/r-libarrow-linux-x86_64-26.0.1.zip.sha512 | Adds Linux x86-64 binary checksum. |
| r/tools/checksums/r-libarrow-linux-arm64-26.0.1.zip.sha512 | Adds Linux ARM64 binary checksum. |
| r/tools/checksums/r-libarrow-darwin-x86_64-26.0.1.zip.sha512 | Adds macOS x86-64 binary checksum. |
| r/tools/checksums/r-libarrow-darwin-arm64-26.0.1.zip.sha512 | Adds macOS ARM64 binary checksum. |
| r/README.md | Removes badges for CRAN submission. |
| r/R/dplyr-funcs-doc.R | Updates the documented compute-function count. |
| r/pkgdown/assets/versions.json | Updates R documentation version navigation. |
| r/pkgdown/assets/versions.html | Updates R documentation version links. |
| r/NEWS.md | Adds release headings and offline-build news. |
| r/man/acero.Rd | Synchronizes the compute-function count in help. |
| r/Makefile | Runs dependency vendoring during source synchronization. |
| r/inst/COPYRIGHTS | Records bundled dependency licenses and attribution. |
| r/DESCRIPTION | Sets R version 26.0.1.1 and copyright reference. |
| r/configure.win | Removes separate Brotli linker flags. |
| r/.Rbuildignore | Allows bundled archives while excluding vendoring tools/cache. |
| r/.gitignore | Ignores generated dependency archives and download cache. |
| python/pyproject.toml | Sets fallback package version to 26.0.1. |
| python/CMakeLists.txt | Sets PyArrow build version to 26.0.1. |
| matlab/CMakeLists.txt | Sets MATLAB build version to 26.0.1. |
| docs/source/developers/cpp/building.rst | Documents dependency checksum overrides. |
| docs/source/_static/versions.json | Advances stable and development documentation versions. |
| dev/tasks/tasks.yml | Adds offline vendored-dependency R verification. |
| dev/tasks/r/github.packages.yml | Selects R 4.1 for Rtools40 builds. |
| dev/tasks/r/github.linux.cran.yml | Refreshes CRAN-like compiler images. |
| dev/tasks/macros.jinja | Corrects the Homebrew formula destination. |
| dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in | Adds release changelog entries. |
| dev/tasks/linux-packages/apache-arrow/debian/control.in | Adds conditional OpenTelemetry runtime dependency. |
| dev/tasks/linux-packages/apache-arrow/debian/changelog | Adds Debian release entries. |
| dev/tasks/linux-packages/apache-arrow-release/yum/apache-arrow-release.spec.in | Adds repository-package release entries. |
| dev/tasks/linux-packages/apache-arrow-apt-source/debian/changelog | Adds APT-source release entries. |
| dev/tasks/homebrew-formulae/apache-arrow.rb | Updates release URL and LLVM prefix lookup. |
| dev/tasks/homebrew-formulae/apache-arrow-glib.rb | Updates the GLib release URL. |
| dev/release/verify-apt.sh | Checks runtime library dependencies before development packages. |
| dev/release/utils-prepare.sh | Handles digits in Debian package-name prefixes. |
| dev/release/rat_exclude_files.txt | Excludes the copyright inventory from license-header checks. |
| dev/release/download_rc_binaries.py | Accepts curl release-candidate version strings. |
| cpp/vcpkg.json | Updates Arrow version and dependency baseline. |
| cpp/thirdparty/versions.txt | Updates bundled Brotli and Thrift versions/checksums. |
| cpp/src/parquet/thrift_internal.h | Rejects unsupported compression codec values. |
| cpp/src/parquet/reader_test.cc | Updates JSON expectations for simdjson 5. |
| cpp/src/parquet/metadata.cc | Preserves encryption metadata and uses GCM footer signatures. |
| cpp/src/parquet/metadata_test.cc | Tests unsupported compression codec rejection. |
| cpp/src/parquet/file_writer.cc | Carries per-column chunking state across row groups. |
| cpp/src/parquet/encryption/write_configurations_test.cc | Expands encryption and footer-signature coverage. |
| cpp/src/parquet/encryption/internal_file_encryptor.cc | Uses GCM for plaintext-footer signing. |
| cpp/src/parquet/column_writer.h | Adds a private factory accepting shared chunking state. |
| cpp/src/parquet/column_writer.cc | Uses file-provided chunkers in column writers. |
| cpp/src/parquet/chunker_internal.h | Supports movable chunkers and documents file ownership. |
| cpp/src/parquet/chunker_internal.cc | Optimizes hashing and supports binary/string views. |
| cpp/src/parquet/chunker_internal_test.cc | Tests view types and row-group-independent boundaries. |
| cpp/src/parquet/arrow/reader_writer_benchmark.cc | Benchmarks serial and threaded content-defined chunking. |
| cpp/src/gandiva/precompiled/extended_math_ops.cc | Checks rounding precision before negation. |
| cpp/src/gandiva/precompiled/extended_math_ops_test.cc | Tests rounding precision boundaries. |
| cpp/src/arrow/util/async_generator_test.cc | Skips threading-dependent tests in non-threaded builds. |
| cpp/src/arrow/ipc/reader.cc | Rejects invalid map child null counts safely. |
| cpp/src/arrow/compute/kernels/vector_selection.cc | Handles zero-chunk input in nonzero selection. |
| cpp/src/arrow/compute/kernels/vector_selection_test.cc | Covers nonzero selection on zero-chunk arrays. |
| cpp/meson.build | Sets C++ release version to 26.0.1. |
| cpp/examples/minimal_build/system_dependency.dockerfile | Installs the uriparser development dependency. |
| cpp/CMakeLists.txt | Sets C++ release version to 26.0.1. |
| cpp/cmake_modules/thrift-3187.patch | Removes the obsolete Thrift patch. |
| cpp/cmake_modules/ThirdpartyToolchain.cmake | Supports checksum overrides and updated dependency builds. |
| cpp/cmake_modules/SetupCxxFlags.cmake | Scopes MSVC SIMD definitions to enabled instructions. |
| compose.yaml | Removes the obsolete R Clang-update build argument. |
| ci/vcpkg/ports.patch | Refreshes dependency compatibility patches. |
| ci/scripts/r_windows_build.sh | Stops packaging separate Brotli archives. |
| ci/scripts/r_test.sh | Simulates offline builds and verifies expected features. |
| ci/scripts/r_docker_configure.sh | Installs legacy timezone data where available. |
| ci/scripts/PKGBUILD | Updates version and builds bundled Brotli. |
| ci/docker/linux-r.dockerfile | Removes obsolete Clang-update configuration. |
| ci/docker/conda-integration.dockerfile | Installs jpype1 through conda. |
| CHANGELOG.md | Adds Arrow 26.0.0 and 26.0.1 release notes. |
| c_glib/vcpkg.json | Updates GLib version and dependency baseline. |
| c_glib/meson.build | Sets GLib release version to 26.0.1. |
| .github/workflows/r.yml | Relies on R 4.1 to select Rtools40. |
| .github/workflows/package_linux.yml | Uses runner temporary storage for reproducibility checks. |
| .github/actions/odbc-windows/action.yml | Installs pinned vcpkg with patched overlay ports. |
| .env | Updates vcpkg pin and Windows wheel image revision. |
Review effort: Balanced
Comment on lines
+933
to
+937
| if (use_vendored_deps || !thirdparty_deps_unavailable) { | ||
| return(invisible(TRUE)) | ||
| } | ||
| offline_build <- env_is("ARROW_OFFLINE_BUILD", "true") | ||
| stop( |
| return(character()) | ||
| } | ||
| expected <- read_thirdparty_checksums(file.path(src_dir, "thirdparty", "versions.txt")) | ||
| deps_df <- get_component_names() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Do not merge.
Checklist issue: #55680.