GH-50690: [C++] Migrate ObjectWriter users to JsonWriter - #50691
Merged
Conversation
|
|
pitrou
reviewed
Jul 28, 2026
pitrou
approved these changes
Jul 29, 2026
pitrou
left a comment
Member
There was a problem hiding this comment.
+1, thanks for working on this @Reranko05 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR continues the simdjson migration by replacing the remaining
ObjectWriterusers withJsonWriter. With all usages migrated, the obsoleteObjectWriterimplementation and its associated build configuration are removed.What changes are included in this PR?
Replace
ObjectWriterwithJsonWriterin:key_material.cckey_metadata.cclocal_wrap_kms_client.ccfile_system_key_material_store.ccRemove the unused
ObjectWriterimplementation (object_writer.ccandobject_writer.h).Remove
object_writer.hfrom the installed headers.Update the Arrow build configuration to stop building
object_writer.cc.Link Parquet against
simdjson::simdjsonsince it now includesjson_writer_internal.h.Are these changes tested?
Yes.
Are there any user-facing changes?
No.
Closes: #50690