Skip to content

GH-50690: [C++] Migrate ObjectWriter users to JsonWriter - #50691

Merged
pitrou merged 4 commits into
apache:mainfrom
Reranko05:gh-35460-pr3
Jul 29, 2026
Merged

GH-50690: [C++] Migrate ObjectWriter users to JsonWriter#50691
pitrou merged 4 commits into
apache:mainfrom
Reranko05:gh-35460-pr3

Conversation

@Reranko05

@Reranko05 Reranko05 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

This PR continues the simdjson migration by replacing the remaining ObjectWriter users with JsonWriter. With all usages migrated, the obsolete ObjectWriter implementation and its associated build configuration are removed.

What changes are included in this PR?

  • Replace ObjectWriter with JsonWriter in:

    • key_material.cc
    • key_metadata.cc
    • local_wrap_kms_client.cc
    • file_system_key_material_store.cc
  • Remove the unused ObjectWriter implementation (object_writer.cc and object_writer.h).

  • Remove object_writer.h from the installed headers.

  • Update the Arrow build configuration to stop building object_writer.cc.

  • Link Parquet against simdjson::simdjson since it now includes json_writer_internal.h.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Closes: #50690

@Reranko05
Reranko05 requested review from pitrou and wgtmac as code owners July 28, 2026 15:57
Copilot AI review requested due to automatic review settings July 28, 2026 15:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Reranko05 Reranko05 changed the title GH-50690: Migrate ObjectWriter users to JsonWriter GH-50690: [C++] Migrate ObjectWriter users to JsonWriter Jul 28, 2026
@github-actions github-actions Bot added the awaiting review Awaiting review label Jul 28, 2026
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #50690 has been automatically assigned in GitHub to PR creator.

Comment thread cpp/src/arrow/CMakeLists.txt Outdated
Comment thread cpp/src/parquet/encryption/key_material.cc
Comment thread cpp/src/parquet/encryption/key_metadata.cc Outdated
@github-actions github-actions Bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jul 28, 2026
Copilot AI review requested due to automatic review settings July 28, 2026 16:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings July 29, 2026 08:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks for working on this @Reranko05 !

@pitrou
pitrou merged commit 3deec0b into apache:main Jul 29, 2026
56 of 61 checks passed
@pitrou pitrou removed the awaiting committer review Awaiting committer review label Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C++] Remove ObjectWriter after JsonWriter migration

3 participants