GH-50648: [Packaging][Linux] Enable OpenTelemetry - #50650
Open
kou wants to merge 20 commits into
Open
Conversation
|
|
Member
Author
|
@github-actions crossbow submit -g wheel -g r *emscripten |
|
Revision: 9c7c84c Submitted crossbow builds: ursacomputing/crossbow @ actions-2a277f2dc1
|
Member
Author
|
@github-actions crossbow submit test-conda-python-emscripten |
|
Revision: dc0fb97 Submitted crossbow builds: ursacomputing/crossbow @ actions-446f8349e0
|
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.
Suppressed comments (1)
cpp/src/arrow/ArrowConfig.cmake.in:85
- In this
if()branch, usingif(${dependency} STREQUAL "opentelemetry-cpp")is fragile because unquoted values can be re-interpreted by CMake’sif()expression rules (e.g., as variable/keyword tokens), which can lead to unexpected evaluation if the dependency list ever contains an empty element or a token that matches an existing variable/keyword. Quoting the expanded value makes the comparison robust.
if(${dependency} STREQUAL "opentelemetry-cpp")
find_dependency(${dependency}
COMPONENTS
exporters_ostream
exporters_otlp_http
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Debian GNU/Linux trixie or later and Ubuntu 26.04 or later provide opentelemetry-cpp-dev:
What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.