GH-48740: [C++] Add missing CTypeTraits for decimal types#50153
Open
Naurder wants to merge 2 commits into
Open
GH-48740: [C++] Add missing CTypeTraits for decimal types#50153Naurder wants to merge 2 commits into
Naurder wants to merge 2 commits into
Conversation
Author
|
Hi @HuaHuaY and @zanmato1984, |
HuaHuaY
reviewed
Jun 11, 2026
| /// \addtogroup type-traits | ||
| /// @{ | ||
| template <> | ||
| struct CTypeTraits<Decimal128> { |
Contributor
There was a problem hiding this comment.
I think it should inherit TypeTraits<Decimal128Type> like other specialization.
Author
There was a problem hiding this comment.
Done. Thank you very much for suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
As reported in #48740, the
CTypeTraitsspecializations were missing for decimal types. This prevented generic code from correctly mapping C++ decimal types to Arrow types.What changes are included in this PR?
CTypeTraits<Decimal128>mapping toDecimal128Type.CTypeTraits<Decimal256>mapping toDecimal256Type.Are these changes tested?
Yes, via existing type traits tests in the CI pipeline.
Are there any user-facing changes?
No.
Closes #48740