prevent scheduler crash on non-ASCII DAG/TaskGroup names with OTel metrics enabled#68124
Open
bujjibabukatta wants to merge 2 commits into
Open
prevent scheduler crash on non-ASCII DAG/TaskGroup names with OTel metrics enabled#68124bujjibabukatta wants to merge 2 commits into
bujjibabukatta wants to merge 2 commits into
Conversation
… False instead of crashing scheduler on non-ASCII DAG/TaskGroup names (apache#68018)
…n-ASCII DAG names in name_is_otel_safe() (apache#68018)
Contributor
|
Could you please rename the PR's title to a meaningful name? (for example, "Fix non-ascii...") |
bujjibabukatta
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68018
Addresses all points raised in the previous review:
from ..exceptions import InvalidStatsNameExceptionso theexceptclause inname_is_otel_safe()correctly catches the exception instead of raisingNameErrorTestNameIsOtelSaferegression tests — non-ASCII names returnFalsewithout raising, valid ASCII names still returnTruename_is_otel_safein the test file so the new tests can run