Repository navigation
fix(github-actions): pin context.sha during org file sync and validate preview artifact metadata - #4025
Open
josephperrott wants to merge 2 commits into
Open
fix(github-actions): pin context.sha during org file sync and validate preview artifact metadata#4025josephperrott wants to merge 2 commits into
josephperrott wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces unit tests and refactors code for testability across two GitHub Actions: org-file-sync and upload-artifacts-to-firebase. Specifically, it exports core functions, adds validation for commit SHAs and artifact metadata against trusted workflow payloads, and configures Bazel targets for Jasmine testing. Feedback on these changes suggests removing .trim() from the SHA validation regex to prevent passing untrimmed strings with whitespace to the GitHub API, and using optional chaining when accessing payload.workflow_run to avoid potential runtime errors if the parsed JSON is null.
josephperrott
force-pushed
the
fix/sync-pinning-and-preview-validation
branch
from
October 9, 2026 18:55
f07f6a6 to
b793301
Compare
josephperrott
force-pushed
the
fix/sync-pinning-and-preview-validation
branch
from
October 9, 2026 19:08
b793301 to
9bf5a3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin context.sha when reading source files in org-file-sync and validate extracted preview artifact metadata (pull-number and build-revision) against the workflow_run event payload.