Repository navigation
fix(github-actions): enforce approval SHA freshness and harden post-approval review requests - #4024
Open
josephperrott wants to merge 4 commits into
Open
josephperrott wants to merge 4 commits into
josephperrott wants to merge 4 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the post-approval changes GitHub Action by extracting its core logic into a separate module, adding comprehensive unit tests, and enhancing its behavior to handle reopened events, ignore comment-only reviews, and re-request reviews from all stale approvers. Additionally, it updates the pull request validation to ensure that at least one team member's review is on the latest commit. The review feedback suggests wrapping individual token revocations in separate try-catch blocks within the finally block to prevent token leaks if one revocation fails, and adding defensive null checks for the review object during validation to avoid potential runtime crashes.
…st-approval-changes
…shness in assertMinimumReviews
josephperrott
force-pushed
the
fix/review-gate-sha-freshness
branch
from
October 9, 2026 18:54
6d84029 to
8637afd
Compare
…tained in post-approval-changes
josephperrott
force-pushed
the
fix/review-gate-sha-freshness
branch
from
October 9, 2026 19:14
8637afd to
0b46e3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce commit SHA freshness on pull request approvals across post-approval-changes and assertMinimumReviews, ignore trailing COMMENTED reviews when deduplicating reviewer states, re-request all stale Googler approvers, and fail closed if the googlers org installation token cannot be obtained.