Repository navigation
docs(material/datepicker): make comparison range distinguishable in example - #34090
Open
vinaycookscode wants to merge 1 commit into
Open
vinaycookscode wants to merge 1 commit into
vinaycookscode wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
angular-robot
Bot
added
area: docs
…xample The comparison range in the date range picker comparison example uses the tertiary container colour, which is barely distinguishable from the primary range in some M3 themes (e.g. azure). The calendar renders in an overlay outside of the example component, so the colour tokens are overridden through a `panelClass` instead of on the host element. Also switches the example to `ViewEncapsulation.None` so that the panel class styles apply, like the views selection example. Fixes angular#31663
vinaycookscode
force-pushed
the
docs/datepicker-comparison-colors
branch
from
November 6, 2026 19:45
f44d31b to
a7bf4dc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31663
The comparison range in the date range picker comparison example uses the tertiary container colour, which is barely distinguishable from the primary range in some M3 themes (e.g. azure).
This is a follow-up to #34066, which had no visible effect. The calendar renders in an overlay outside the example component, so overriding the colour tokens on the host element never reached it. The tokens are now set through a
panelClass, and the example usesViewEncapsulation.Noneso the panel styles apply, as in the views selection example.I tested this in a local Angular Material app with an azure theme. The comparison range is now amber while the primary range stays blue.
Before:
After:
