Repository navigation
docs(material/datepicker): make comparison range distinguishable in example - #34089
Closed
vinaycookscode wants to merge 1 commit into
Closed
vinaycookscode wants to merge 1 commit into
vinaycookscode wants to merge 1 commit into
Conversation
The comparison-range example uses tertiary-container as its background in M3, which is nearly identical to primary-container in several default themes (e.g. Azure & Blue). The two overlapping campaign date ranges become visually indistinguishable at a glance. Override two CSS custom properties scoped to the example host element with an amber tint — the same colour Material 2 used — so the visual distinction is clear in every M3 theme. This has no effect on user apps. Fixes angular#31663
angular-robot
Bot
added
area: docs
vinaycookscode
changed the title
panelClass, and the example uses ViewEncapsulation.None so the panel styles apply, as in the views selection example. I tested this in a local Angular Material app with an azure theme. The comparison range is now amber while the primary range stays blue. Before: <drag before.png here> After: <drag after.png here>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31663
The comparison range in the date range picker comparison example uses the tertiary container colour, which is barely distinguishable from the primary range in some M3 themes (e.g. azure).
This is a follow-up to #34066, which had no visible effect. The calendar renders in an overlay outside the example component, so overriding the colour tokens on the host element never reached it. The tokens are now set through a
panelClass, and the example usesViewEncapsulation.Noneso the panel styles apply, as in the views selection example.I tested this in a local Angular Material app with an azure theme. The comparison range is now amber while the primary range stays blue.
Before:
After:
