Security hardening fixes#33377
Open
crisbeto wants to merge 8 commits into
Open
Conversation
Adds some logic to avoid accidental HTML injection through the Markdown renderer.
Avoids command injection in the API golden script by using `exec` instead of interpolating the entire command.
Reworks the package archive script to avoid command injection by going through `exec` instead of constructing the command using string concatenation.
Makes the check whether an input is a modifier more robust against prototype pollution.
The media matcher needs to create a dummy stylesheet to work around some browser quirks. These changes ensure we don't accidentally inject malicious CSS into the page.
The `animationDuration` input is a potential CSS injection attack vector, because we pass the value directly along to the `animation-duration` binding. These changes mitigate the risk by validating the incoming value.
We were dropping the `colspan` validation error in production mode which meant that it can go into an infinite loop.
Previous we were relying on the animation name to ensure that we only capture the correct animation. These changes harden it by also checking the event's `target`.
crisbeto
added
target: patch
angular-robot
Bot
added
area: build & ci
ok7sai
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes some fixes for potential security issues. See the individual commits for context.