fix(inkless): repair missing control-plane rows on CreatePartitions retry [KC-420] - #752
Merged
Merged
Conversation
viktorsomogyi
force-pushed
the
svv/fix-create-partitions-missing-logs-rows
branch
from
August 14, 2026 13:43
370f426 to
7e6c736
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens Inkless diskless-topic partition creation and consolidation behavior by making CreatePartitions retries repair missing control-plane rows and by preventing placeholder control-plane LATEST offsets from incorrectly truncating classic prefixes below the committed KRaft seal.
Changes:
- Update controller CreatePartitions handling to generate control-plane insert requests for “born-diskless” partitions on retries, including non-contiguous ranges and skipping sealed/switching partitions when the image indicates them.
- Clamp diskless LATEST offsets (and epoch end offsets derived from LATEST) to at least the committed seal to avoid truncation from placeholder rows.
- Expand unit test coverage for both behaviors across controller and diskless leader endpoint paths.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| storage/inkless/src/main/java/io/aiven/inkless/control_plane/CreateTopicAndPartitionsRequest.java | Updates API documentation to reflect range-based partition insertion semantics for retries/holes. |
| core/src/main/scala/kafka/server/ControllerApis.scala | Implements retry-aware control-plane row insertion, including partition classification and contiguous range batching. |
| core/src/test/scala/unit/kafka/server/ControllerApisTest.scala | Adds tests covering CreatePartitions retry scenarios, sealed/switching skips, non-contiguous insertion, and decrease rejection. |
| core/src/main/scala/io/aiven/inkless/consolidation/DisklessLeaderEndPoint.scala | Ensures LATEST-derived offsets are never below the committed seal and keeps leader epoch resolution consistent with the adjusted offset. |
| core/src/test/scala/io/aiven/inkless/consolidation/DisklessLeaderEndPointTest.scala | Adds tests validating seal clamping behavior for LATEST and for epoch end offsets. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…etry A failed control-plane write after KRaft already applied the increase left partitions advertised but unusable; retry returned INVALID_PARTITIONS and skipped the insert. Also treat a diskless LATEST below the committed seal as the seal, so a placeholder row cannot truncate the classic prefix. Co-authored-by: Cursor <cursoragent@cursor.com>
viktorsomogyi
force-pushed
the
svv/fix-create-partitions-missing-logs-rows
branch
from
August 14, 2026 13:54
7e6c736 to
9f28516
Compare
viktorsomogyi
changed the title
viktorsomogyi
marked this pull request as ready for review
August 14, 2026 14:36
jeqo
reviewed
Aug 17, 2026
jeqo
left a comment
jeqo
left a comment
Contributor
There was a problem hiding this comment.
Looking good. Left a few comments before approving.
…s writes CreatePartitions never returns that error; it was copied from create-topic. Co-authored-by: Cursor <cursoragent@cursor.com>
…ification The decrease check and the born-diskless filter must see the same snapshot. Co-authored-by: Cursor <cursoragent@cursor.com>
… or equal Switch-pending and born-diskless must not raise LATEST; equality with the seal is already correct. Co-authored-by: Cursor <cursoragent@cursor.com>
jeqo
approved these changes
Aug 18, 2026
jeqo
pushed a commit
that referenced
this pull request
Aug 19, 2026
…etry [KC-420] (#752) * fix(inkless): repair missing control-plane rows on CreatePartitions retry A failed control-plane write after KRaft already applied the increase left partitions advertised but unusable; retry returned INVALID_PARTITIONS and skipped the insert. Also treat a diskless LATEST below the committed seal as the seal, so a placeholder row cannot truncate the classic prefix. --------- Co-authored-by: Cursor <cursoragent@cursor.com>
jeqo
pushed a commit
that referenced
this pull request
Aug 19, 2026
…etry [KC-420] (#752) * fix(inkless): repair missing control-plane rows on CreatePartitions retry A failed control-plane write after KRaft already applied the increase left partitions advertised but unusable; retry returned INVALID_PARTITIONS and skipped the insert. Also treat a diskless LATEST below the committed seal as the seal, so a placeholder row cannot truncate the classic prefix. --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed control-plane write after KRaft already applied the increase left partitions advertised but unusable; retry returned INVALID_PARTITIONS and skipped the insert. Also treat a diskless LATEST below the committed seal as the seal, so a placeholder row cannot truncate the classic prefix.