Repository navigation
feat(server): add server side cache - #301
Open
namrataghadi-galileo wants to merge 4 commits into
Open
namrataghadi-galileo wants to merge 4 commits into
namrataghadi-galileo wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Author
Collaborator
|
@namrataghadi-galileo nice work on this. The core design looks right to me:
A few things I would like addressed before we turn it on broadly:
Follow-ups, not blocking:
|
wrisa
reviewed
Nov 4, 2026
| self, namespace: str, agent: str, target_type: str | None, target_id: str | None | ||
| ) -> None: | ||
| del namespace, agent, target_type, target_id | ||
| _CACHE_MISS.inc() |
Collaborator
There was a problem hiding this comment.
There is no cache to miss then why increment this counter?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
ControlCacheinterface withNoOpControlCacheas the default and an optional Redis implementation for effective-control snapshots.AGENT_CONTROL_*settings, TTL fallback, and fail-open evaluation when Redis is unavailable.KEYS.Compatibility
redis>=5.2.1); the default backend is PostgreSQL and OSS deployments do not require Redis.Testing
make server-test— 1019 passed.make typecheck— passed.