return promptRequired when no turn is running - #363
Open
lifeizhou-ap wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A steering request can arrive just as the active turn ends. Codex ACP currently starts a new turn itself and returns
startedNewTurn, leaving the client without a normalsession/promptrequest to await or cancel.This PR adds the opt-in behavior introduced in Claude ACP #919.
When the client sends:
{ "_meta": { "steering": { "idleBehavior": "promptRequired" } } }Codex ACP:
injectedif a turn is running.promptRequiredif the turn has ended, without starting another turn.session/prompt.startedNewTurnwhen the option is not provided.Verification
npm run typechecknpm testnpm run buildnpm run example:steering