Repository navigation
Conversation
vgreb
force-pushed
the
refacto/doctrine-accounting-4-entites-invoicing
branch
from
October 27, 2026 21:01
43a85e0 to
3fc3f80
Compare
stakovicz
reviewed
Nov 4, 2026
Ajout du mapping seul, sans toucher aux appelants : Ting reste en place et continue de servir les devis et les factures. InvoicingRepository s'appuie sur InvoicingPeriodRepository, introduit avec la migration du journal.
vgreb
force-pushed
the
refacto/doctrine-accounting-4-entites-invoicing
branch
from
November 7, 2026 23:02
3fc3f80 to
5741baa
Compare
21 of 31 tasks
stakovicz
reviewed
Nov 10, 2026
Comment on lines
+24
to
+25
| #[ORM\Column(name: 'date_devis', nullable: true)] | ||
| public ?\DateTime $dateDevis = null; |
Member
There was a problem hiding this comment.
**suggestion : ** ajouter le type type: Types::DATE_MUTABLE(idem pour dateFacture et datePaiement)
| #[ORM\Column] | ||
| public ?int $id = null; | ||
|
|
||
| #[ORM\Column(name: 'date_devis', nullable: true)] |
Member
There was a problem hiding this comment.
question : t'es sûr du nullable:true ?
| 'count' => 1, | ||
| 'path' => __DIR__ . '/sources/Afup/Utils/Vat.php', | ||
| ]; | ||
| $ignoreErrors[] = [ |
Member
There was a problem hiding this comment.
🚨 Woot woot 🚨
On n'a pas le droit d'ajouter une baseline 😬
| #[ORM\Column(name: 'date_devis', nullable: true)] | ||
| public ?\DateTime $dateDevis = null; | ||
|
|
||
| #[ORM\Column(name: 'numero_devis', nullable: true)] |
Member
There was a problem hiding this comment.
issue : il manque la longueur de la colonne, non ?
| #[ORM\Column(name: 'pu', type: 'float', nullable: false)] | ||
| public ?float $prixUnitaire = null; | ||
|
|
||
| #[Assert\NotBlank] |
Member
There was a problem hiding this comment.
issue : ce n'est pas cohérent avec le typage Doctrine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ajout du mapping seul, sans toucher aux appelants : Ting reste en place et continue de servir les devis et les factures.
InvoicingRepository s'appuie sur InvoicingPeriodRepository, introduit avec la migration du journal.