Skip to content

Fix draw_polygon and draw_circle leaving pixels off the screen #11701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhalbert merged 2 commits into from
Nov 1, 2026
Merged

Fix draw_polygon and draw_circle leaving pixels off the screen #11701

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29fd483
bitmaptools: include the last row and column in draw_polygon's dirty …
mikeysklar Nov 1, 2026
fe12944
bitmaptools: include the last row and column in draw_circle's dirty area
mikeysklar Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions shared-module/bitmaptools/__init__.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ void common_hal_bitmaptools_draw_polygon(displayio_bitmap_t *destination, void *
draw_line(destination, xprev, yprev, x0, y0, value);
}

displayio_area_t area = { xmin, ymin, xmax, ymax, NULL };
displayio_area_t area = { xmin, ymin, xmax + 1, ymax + 1, NULL };
displayio_area_t bitmap_area = { 0, 0, destination->width, destination->height, NULL };
displayio_area_compute_overlap(&area, &bitmap_area, &area);
displayio_bitmap_set_dirty_area(destination, &area);
Expand Down Expand Up @@ -1069,9 +1069,9 @@ void common_hal_bitmaptools_draw_circle(displayio_bitmap_t *destination,
int16_t xbb0, xbb1, ybb0, ybb1;

xbb0 = x - radius;
xbb1 = x + radius;
xbb1 = x + radius + 1;
ybb0 = y - radius;
ybb1 = y + radius;
ybb1 = y + radius + 1;

displayio_area_t area = { xbb0, ybb0, xbb1, ybb1, NULL };
displayio_area_t bitmap_area = { 0, 0, destination->width, destination->height, NULL };
Expand Down
Loading