Fix misleading error/debug messages in run-container-step.ts#370
Merged
Conversation
- Rename debug message from 'createJob failed' to 'createContainerStepPod failed' - Update thrown error messages from 'failed to run script step' to 'failed to run container step' in both catch blocks
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Fix misleading error/debug messages in run-container-step.ts
Jun 4, 2026
nikola-jokic
approved these changes
Jun 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates logging and thrown error messages in runContainerStep to use consistent “container step” terminology, reducing confusion when debugging container-step failures in the Kubernetes hook.
Changes:
- Update the pod-creation debug message to reference
createContainerStepPodrather thancreateJob. - Update thrown errors in the pod-creation and exec error paths to say “failed to run container step” instead of “script step”.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
@copilot fix merge conflict |
Contributor
Author
rentziass
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error and debug messages in
runContainerStepreferenced "script step" and "createJob" terminology, causing confusion when diagnosing container step failures.Changes
packages/k8s/src/hooks/run-container-step.tscreateJob failed→createContainerStepPod failedfailed to run script step→failed to run container stepfailed to run script step→failed to run container step