login.php for client 14?

[Pablodotnet]

In the process of updating my canary server to v14 with latest release, I'm not able to log in using the client 14, I'm still able on client 13 but on client 14 I dont pass from the character selection screen, it makes failed attempts to enter.

[luanluciano93]

Has anything changed in the login?

[Pablodotnet]

I think it did! I can continue to log in using client 13 but with client 14 I just get to the characters and after selecting it, it doesn’t connect it just makes failed attempts

[Znote]

What has changed in the login?

This is the webService login payload logic:

ZnoteAAC/login.php

Lines 142 to 291 in 61d0bfc

	case "login":
	/* {
	'accountname' => 'username',
	"email":"my@email.com",
	'password' => 'superpass',
	'stayloggedin' => true,
	'token' => '123123', (or not set)
	'type' => 'login',
	} */
	$email = (isset($client->email)) ? sanitize($client->email) : false;
	$username = (isset($client->accountname)) ? sanitize($client->accountname) : false;
	$password = SHA1($client->password);
	$token = (isset($client->token)) ? sanitize($client->token) : false;
	$fields = '`id`, `premium_ends_at`';
	if ($config['twoFactorAuthenticator']) $fields .= ', `secret`';
	$account = false;
	if ($email !== false) {
	$fields .= ', `name`';
	$account = mysql_select_single("SELECT {$fields} FROM `accounts` WHERE `email`='{$email}' AND `password`='{$password}' LIMIT 1;");
	if ($account !== false) {
	$username = $account['name'];
	}
	} elseif ($username !== false) {
	$account = mysql_select_single("SELECT {$fields} FROM `accounts` WHERE `name`='{$username}' AND `password`='{$password}' LIMIT 1;");
	}
	if ($account === false) {
	sendError('Wrong username and/or password.');
	}
	if ($config['twoFactorAuthenticator'] === true && $account['secret'] !== null) {
	if ($token === false) {
	sendError('Submit a valid two-factor authentication token.', 6);
	} else {
	require_once("engine/function/rfc6238.php");
	if (TokenAuth6238::verify($account['secret'], $token) !== true) {
	sendError('Two-factor authentication failed, token is wrong.', 6);
	}
	}
	}
	$players = mysql_select_multi("SELECT `name`, `sex`, `level`, `vocation`, `lookbody`, `looktype`, `lookhead`, `looklegs`, `lookfeet`, `lookaddons`, `deletion` FROM `players` WHERE `account_id`='".$account['id']."';");
	if ($players !== false) {
	$gameserver = $config['gameserver'];
	// Override $config['gameserver'] if server has installed Lua script for loginWebService
	$sql_elements = mysql_select_multi("
	SELECT
	`key`,
	`value`
	FROM `znote_global_storage`
	WHERE `key` IN('SERVER_NAME', 'IP', 'GAME_PORT')
	");
	if ($sql_elements !== false) {
	foreach ($sql_elements AS $element) {
	switch ($element['key']) {
	case 'SERVER_NAME':
	$gameserver['name'] = $element['value'];
	break;
	case 'IP':
	$gameserver['ip'] = $element['value'];
	break;
	case 'GAME_PORT':
	$gameserver['port'] = (int)$element['value'];
	break;
	}
	}
	}
	$sessionKey = ($email !== false) ? $email."\n".$client->password : $username."\n".$client->password;
	$sessionKey .= (isset($account['secret']) && strlen($account['secret']) > 5) ? "\n".$token : "\n";
	$sessionKey .= "\n".floor(time() / 30);
	$freePremium = (isset($config['freePremium'])) ? $config['freePremium'] : true;
	$response = array(
	'session' => array(
	'fpstracking' => false,
	'optiontracking' => false,
	'isreturner' => true,
	'returnernotification' => false,
	'showrewardnews' => false,
	'tournamentticketpurchasestate' => 0,
	'emailcoderequest' => false,
	'sessionkey' => $sessionKey,
	'lastlogintime' => 0,
	'ispremium' => ($account['premium_ends_at'] > time() || $freePremium) ? true : false,
	'premiumuntil' => $account['premium_ends_at'],
	'status' => 'active'
	),
	'playdata' => array(
	'worlds' => array(
	array(
	'id' => 0,
	'name' => $gameserver['name'],
	'externaladdress' => $gameserver['ip'],
	'externalport' => $gameserver['port'],
	'previewstate' => 0,
	'location' => 'ALL',
	// 0 - open pvp
	// 1 - optional
	// 2 - hardcore
	// 3 - retro open pvp
	// 4 - retro hardcore pvp
	// 5 and higher - (unknown)
	'pvptype' => 0,
	'externaladdressunprotected' => $gameserver['ip'],
	'externaladdressprotected' => $gameserver['ip'],
	'externalportunprotected' => $gameserver['port'],
	'externalportprotected' => $gameserver['port'],
	'istournamentworld' => false,
	'restrictedstore' => false,
	'currenttournamentphase' => 2,
	'anticheatprotection' => false
	)
	),
	'characters' => array(
	//array( 'worldid' => ASD, 'name' => asd, 'ismale' => true, 'tutorial' => false ),
	)
	)
	);
	foreach ($players as $player) {
	$response['playdata']['characters'][] = array(
	'worldid' => 0,
	'name' => $player['name'],
	'ismale' => ($player['sex'] === 1) ? true : false,
	'tutorial' => false,
	'level' => intval($player['level']),
	'vocation' => vocation_id_to_name($player['vocation']),
	'outfitid' => intval($player['looktype']),
	'headcolor' => intval($player['lookhead']),
	'torsocolor' => intval($player['lookbody']),
	'legscolor' => intval($player['looklegs']),
	'detailcolor' => intval($player['lookfeet']),
	'addonsflags' => intval($player['lookaddons']),
	'ishidden' => intval($player['deletion']) === 1,
	'istournamentparticipant' => false,
	'remainingdailytournamentplaytime' => 0
	);
	}
	sendMessage($response);
	} else {
	sendError("Character list is empty.");
	}
	break;

Usually a character list to in-game issue tends to be related to wrong IP/non public IP configured in config.php:
Edit: The name! I always tend to forget this. Doesn't seem like its important, but the client refuses to connect if server name in config.lua does not directly match!
Perhaps client 14 server got a different name in config.lua?

ZnoteAAC/config.php

Lines 653 to 659 in 61d0bfc

	// Gameserver info is used for client 11+ loginWebService
	$config['login_web_service'] = true; // loginWebService for client 11+ enabled?
	$config['gameserver'] = array(
	'ip' => '127.0.0.1',
	'port' => 7172,
	'name' => 'Forgotten' // Must be identical to config.lua (OT config file) server name.
	);

Can you try to install Lua znote_login revscriptsys:
https://github.com/Znote/ZnoteAAC/blob/v2/Lua/TFS_10/revscriptsys/znote_login.lua

It should help to make sure configurations etc is correct.