Skip to content

Socks5 inbound: Fix issues in new UDP ASSOCIATE#6325

Merged
RPRX merged 6 commits into
mainfrom
socks5-udp
Jun 17, 2026
Merged

Socks5 inbound: Fix issues in new UDP ASSOCIATE#6325
RPRX merged 6 commits into
mainfrom
socks5-udp

Conversation

@Fangliding

Copy link
Copy Markdown
Member

#6323

当初写的时候想着应该遇不到 没想到这么快就有非法请求了
这里是拒绝 或者也能当成0000处理让这些协议错误的软件可以连接

@RPRX

RPRX commented Jun 16, 2026

Copy link
Copy Markdown
Member

我改 #6149 的时候也感觉这里可能会 panic 所以加了个注释

专门构造这种明显不合理的 Socks5 请求,那 APP 是啥成分啊,不过还是当成 0000 处理让它能连上吧


2026/06/13 22:21:11.820187 from tcp:10.163.52.241:53257 accepted udp:40.99.10.82:443 [lan-socks-in >> loopback-out]

此外这行日志有点怪,似乎应该是 udp:10.163.52.241:53257?你看下 @Fangliding

@Fangliding

Copy link
Copy Markdown
Member Author

因为现在 udp in 不走 udp worker 了 所有inbound信息都是从tcp那个 udp associate 请求传来的 然后之前的user什么的都在那上面 算是一点点连带副作用 也不能说全错 毕竟这个udp转发请求确实是这个远端请求引导的 就是log看起来可能向udp

@RPRX

RPRX commented Jun 17, 2026

Copy link
Copy Markdown
Member

@Fangliding 依稀记得 TCP 连接里还没包含要访问的 UDP 目标,所以还是修一下吧,另外这个 PR 改成当 0000 来处理

@RPRX

RPRX commented Jun 17, 2026

Copy link
Copy Markdown
Member

直接改 ctx 里的 inbound 是不是会有 race 等奇奇怪怪的问题,应该把它换个新的?

@RPRX RPRX changed the title Fix panic in illegal request Socks5 inbound: Fix issues in new UDP ASSOCIATE Jun 17, 2026
@RPRX RPRX merged commit 5296061 into main Jun 17, 2026
48 checks passed
RPRX added a commit that referenced this pull request Jun 17, 2026
#6325 (comment)

Fixes #6323

---------

Co-authored-by: RPRX <63339210+RPRX@users.noreply.github.com>
Maolaohei pushed a commit to Maolaohei/Bray-Core that referenced this pull request Jun 17, 2026
XTLS#6325 (comment)

Fixes XTLS#6323

---------

Co-authored-by: RPRX <63339210+RPRX@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants