[in progress] Abilities API: Add REST-level pagination to the run controller#12196
[in progress] Abilities API: Add REST-level pagination to the run controller#12196jorgefilipecosta wants to merge 1 commit into
Conversation
Abilities can opt into standard collection pagination by setting a truthy `pagination` meta value and returning integer `total` and `total_pages` alongside their collection. The run controller then emits the standard X-WP-Total and X-WP-TotalPages headers and rejects out-of-range page requests with a 400 (rest_ability_invalid_page_number), mirroring the core REST collection endpoints. The response body is returned unchanged, so non-REST callers keep the totals.
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Summary
Adds standard, opt-in collection pagination to the Abilities REST run controller, so list-returning abilities get the same
X-WP-Total/X-WP-TotalPagesheaders (and out-of-range handling) as the core REST collection endpoints — without each ability reinventing it.How it works
An ability opts in by setting a truthy
paginationmeta value. Such an ability acceptspage/per_pageinput and returns integertotalandtotal_pagesalongside its collection. The run controller then:X-WP-TotalandX-WP-TotalPagesheaders from those values,400 rest_ability_invalid_page_numberwhen the requested page is beyond the available range, andAbilities without the
paginationmeta are unaffected.Tests
tests/phpunit/tests/rest-api/wpRestAbilitiesV1RunControllerPagination.phpregisters a self-contained paginated test ability and asserts header emission, the unchanged body, the out-of-range 400, and that the last page is allowed.