Fix responsive element styles front end output#12159
Conversation
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
left a comment
ramonjd
left a comment
There was a problem hiding this comment.
Checked code against WordPress/gutenberg#79135 - LGTM
Just had some minor doc nits.
| /** | ||
| * Tests that a responsive element color generates media-query scoped CSS. | ||
| * | ||
| * @ticket 65239 |
There was a problem hiding this comment.
The PR desc has https://core.trac.wordpress.org/ticket/65164 as the ticket. Which one is right?
There was a problem hiding this comment.
| * @ticket 65239 | |
| * @ticket 65239 | |
| * @covers ::wp_render_block_states_support |
There was a problem hiding this comment.
Ah, that's the states one! Either one would do but I chose 65164 so better change this.
| * @param string $root_selector The block root CSS selector. | ||
| * @return string[] Element selectors keyed by element name. | ||
| */ | ||
| function wp_get_block_state_element_selectors( $root_selector ) { |
There was a problem hiding this comment.
WP_Theme_JSON::get_block_element_selectors() seems like it's doing almost the same job with a bit of drift.
Just a note to self for later, maybe WP_Theme_JSON::get_block_element_selectors() could delegate to this shared helper one day
There was a problem hiding this comment.
Yeah there are a couple scenarios where we could replace theme json class functions with shared helpers. I'll check where the opportunities are
tellthemachines
force-pushed
the
fix/responsive-element-styles
branch
from
ee861e7 to
ad5593d
Compare
2 participants
Trac ticket: https://core.trac.wordpress.org/ticket/65164
Copied from Gutenberg PR https://github.com/WordPress/gutenberg/pull/79135/changes with assistance from copilot.