Skip to content

Login and Registration: Underline links on the login screen#12154

Open
itzmekhokan wants to merge 1 commit into
WordPress:trunkfrom
itzmekhokan:feature/65075-underline-login-links
Open

Login and Registration: Underline links on the login screen#12154
itzmekhokan wants to merge 1 commit into
WordPress:trunkfrom
itzmekhokan:feature/65075-underline-login-links

Conversation

@itzmekhokan

Copy link
Copy Markdown

Restores the default underline on the navigation and "Back to" links on wp-login.php so they are clearly identifiable as links.

What the problem was:

  • The .login #nav a, .login #backtoblog a rule in login.css set text-decoration: none, leaving the links with only a muted gray color.
  • Accessibility scanning tools flagged the links as not identifiable, and the accessibility team agreed this hurts usability.

What the fix does:

  • Removes the single text-decoration: none; declaration from that rule, letting the browser-default underline apply.

Approach and why:

  • The generic a rules on the login screen set no text-decoration, so this one declaration was the only thing suppressing the underline. Removing it is the smallest change that achieves the agreed outcome.
  • No !important is needed — WordPress.org used it only to override core from a separate stylesheet; here the source of none is removed directly.
  • The link color and hover/focus styles are intentionally left unchanged.

Trac ticket: https://core.trac.wordpress.org/ticket/65075

Use of AI Tools

N/A


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

The navigation and "Back to" links on wp-login.php were rendered without
an underline because the `.login #nav a, .login #backtoblog a` rule set
`text-decoration: none`. With only a muted gray color to distinguish them,
accessibility scanning tools flagged the links as not identifiable.

Removing the `text-decoration: none` declaration restores the browser
default underline, making the links clearly identifiable. The default
underline is sufficient, so no `!important` override is required.

Following discussion in the accessibility team bug scrub, this was agreed
to meaningfully improve the accessibility and usability of the login
screen.

Props dcavins, audrasjb, khushdoms, joedolson.
See #65075.
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props khokansardar.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant