Fix incorrect casing of Chr() and Ord() in class-pclzip.php#12144
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Replace
Chr()andOrd()with their canonical lowercase formschr()andord().This is flagged as a case-sensitivity violation by the upcoming PHP 8.6 RFC, which will emit
E_DEPRECATEDfor function references that don't match their declared casing. Fixing it now keeps WordPress ahead of the deprecation.Trac ticket: https://core.trac.wordpress.org/ticket/64897
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.