Administration: Fix DivisionByZeroError in wp_dashboard_quota() and d…#12137
Administration: Fix DivisionByZeroError in wp_dashboard_quota() and d…#12137vedant-ere wants to merge 1 commit into
Conversation
…isplay_space_usage() when quota is 0 When a multisite subsite's upload quota is set to 0 MB, both wp_dashboard_quota() and display_space_usage() throw an uncaught DivisionByZeroError on PHP 8.0+ due to unguarded division. - Add an early return in wp_dashboard_quota() when quota <= 0, consistent with the existing early-return pattern in that function. - Add a ternary guard in display_space_usage() to avoid division when space_allowed is 0. Fixes #65439
|
Hi @vedant-ere! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
1 participant
Fixes https://core.trac.wordpress.org/ticket/65439
Problem
On a multisite subsite with a 0 MB upload quota (
blog_upload_space = 0),both
wp_dashboard_quota()anddisplay_space_usage()throw an uncaughtDivisionByZeroErroron PHP 8.0+.get_space_allowed()returns0verbatim becauseis_numeric(0)is true,bypassing the 100 MB fallback. The division then executes with a zero denominator.
Fix
wp_dashboard_quota(): early return when$quota <= 0, consistent withthe existing early-return guards at the top of the function.
display_space_usage(): ternary guard returning0when$space_allowedis not positive.
Testing
PHPUnit tests added in
tests/phpunit/tests/multisite/wpDashboardQuota.phpcovering zero quota, negative quota, normal quota regression, and output assertions.
Use of AI Tools
AI assistance: Yes
Tool(s): Claude
Model(s): Claude Sonnet
Contribution workflow guidance, code review, implementation assistance, and test structure suggestions; verification and testing were performed in my local environment.