Conversation
Add makeSIMDLoadStoreLane and call it from _makenone, makeSIMD, makeNonAtomicLoad, and makeNonAtomicStore. Also guard makeSIMDLoad with allowMemory.
kripken
reviewed
Oct 5, 2026
| if (type == Type::v128) { | ||
| assert(wasm.features.hasSIMD()); | ||
| if (oneIn(2)) { | ||
| return makeSIMDLoadStoreLane(type); |
Member
There was a problem hiding this comment.
Why is the main code path to that function not enough?
Member
Author
There was a problem hiding this comment.
This function can already emit normal SIMD loads when type == Type::v128, so it seems reasonable to let it emit other kinds of SIMD loads as well.
I'm not tied to this, though. Putting SIMDLoadStoreLane only behind makeSIMD also seems reasonable. It will just make it much less likely to be generated, but I guess that's no different from any other SIMD instruction.
I'll make this change.
kripken
reviewed
Oct 5, 2026
| &Self::makeNop, | ||
| &Self::makeGlobalSet) | ||
| .add(FeatureSet::BulkMemory, &Self::makeBulkMemory) | ||
| .add(FeatureSet::SIMD, &Self::makeSIMDLoadStoreLane) |
Member
There was a problem hiding this comment.
It looks like in general we put all SIMD instructions behind makeSIMD()?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add makeSIMDLoadStoreLane and call it from _makenone, makeSIMD,
makeNonAtomicLoad, and makeNonAtomicStore. Also guard makeSIMDLoad with
allowMemory.