Skip to content

[VM-19444] Verify Speakeasy 1.805.0 in Generate and Publish - #81

Merged
noventa-bc merged 2 commits into
mainfrom
noventa-bc/vm-19444-verified-cli-1.805.0
Nov 11, 2026
Merged

noventa-bc merged 2 commits into
mainfrom
noventa-bc/vm-19444-verified-cli-1.805.0

Conversation

@noventa-bc

@noventa-bc noventa-bc commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

Changes

Java Generate and Publish now use checksum-verified CLI 1.805.0, applying the same fix as TypeScript PR88. Missing or modified binaries stop before authentication or release dispatch; every CLI launch is verified, and generation cannot download a different version.

Each existing SDK workflow changes only its uses: line to a same-commit local implementation. Those jobs prepare exact action 6eb2c860da69d3f4cefaa5b8293098a1820c2437 and apply the maintained patch. This is the runtime already selected by the pinned upstream wrapper:

Previously: SDK → sdk-publish.yaml@6f65a213 → action@6eb2c860
Now:        SDK → local speakeasy_publish.yaml → action@6eb2c860 + our patch

Preparation, pin/update tooling, integrity guards, synthetic test fixtures and the narrow Semgrep waiver match TypeScript. The patch additionally declares use_sonatype_legacy, which upstream Go already emits but omits from its action metadata. The Java workflow preserves both legacy Sonatype and Central publishing commands, output gates, action pins and credential mappings. Failed preparation removes the checkout and blocks callbacks.

Routine CLI bumps use python3 .github/actions/prepare-speakeasy/update_cli.py X.Y.Z and change only pinned-cli.json. CI verifies the real artifact against committed hashes without refreshing them. The maintenance guide covers provenance review, source upgrades, patch regeneration and recovery.

Motivation

A configured generator version still allowed an unchecked latest bootstrap to execute. This extends Speakeasy’s recommendation to the Java portion of VM-19444, maintaining the focused patch and required workflow implementations in the SDK repository.

Testing

  • Exact-source preparation/cleanup, 11 Python updater/installer cases, three Go packages, real-artifact checksum checks, workflow lint and shell lint pass. Shared tooling matches TypeScript; the only runtime-patch difference is the Java output declaration.
  • A semantic comparison preserves the reachable upstream Java publish job, including both Sonatype branches, signing environment variables and action pins. Sonatype/GPG secrets remain confined to publishing steps. The original caller diffs are one uses: line each.
  • The actual image builds and reports 1.805.0. Missing/modified CLI checks fail before Release authentication with networking disabled.
  • ./gradlew build sourcesJar javadocJar -Pskip.signing --no-daemon passes on JDK 11. Inspection of binary, sources and Javadoc JARs confirms they exclude the preparation files and fetched action tree. SDK source, dependencies and build configuration are unchanged.
  • Full licensed Java SDK generation and real signing/publication were not run. The action tests remain independent of skip-smoke.

Deployment

Keep this PR draft for review. CLI version remains 1.805.0; generated SDK code and generation locks are unchanged. Existing nightly/manual generation, remote-spec PR review and publish-after-merge policy remain. Complete normal licensed generation and provenance review before adoption; checksums from the same release do not independently authenticate its publisher. Security acceptance of the remaining ticket scope is separate from this CLI fix.

AI Model used and major prompts used

Codex implementation; GPT-6.1 Terra independently checked Java workflow parity, secret boundaries and packaging requirements, and Opus 5.5 reviewed the Java port and maintenance instructions. Requested: port TypeScript’s exact practices with minimal caller diffs, the same pinned runtime and CLI, maintainable update tooling, Java publishing parity and a draft PR.

Co-authored-by: Codex <noreply@openai.com>
@socket-security

socket-security Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedactions/​setup-go@​3041bf56c941b39c61721a86cd11f3bb1338122a9210010010080
Addedactions/​setup-java@​c5195efecf7bdfc987ee8bae7a71cb8b11521c008610010010080
Addedactions/​checkout@​08eba0b27e820071cde6df949e0beb9ba490695599100100100100

View full report

Copy link
Copy Markdown
Collaborator Author

Workflow overview

The entry workflows own triggers and forward inputs/secrets to local implementations from the same SDK commit.

flowchart TD
  G["Generate trigger<br/>sdk_generation.yaml<br/>Nightly or manual"] --> GL["Local generation implementation<br/>speakeasy_generate.yaml"]
  GL --> PR["Pull request"]
  H["Maintainer changes"] --> PR

  PR --> S["Java Smoke Test<br/>smoke_test.yaml"]
  PR -->|"Patch, pin, workflow or config changes"| T["Speakeasy Action Tests<br/>speakeasy_action_test.yaml"]

  PR -->|"Reviewed and merged<br/>gen.lock changed on main"| P["Publish trigger<br/>sdk_publish.yaml"]
  M["Manual publish"] --> P
  P --> R

  subgraph publish["Local Publish implementation · speakeasy_publish.yaml"]
    R["release job<br/>Create release and determine publication"]
    R -->|"Java regenerated and publication enabled"| J["publish-java job<br/>Choose legacy Sonatype or Central"]
  end
Loading

The PR checks run independently. Action Tests also verify the real CLI artifact against the committed pin. Within Publish, the Java job waits for the release job and uses its outputs to choose the publishing branch. Sonatype/GPG credentials are used only in those publishing steps. Each original entry workflow changes only its uses: line.

🤖 Posted by Codex on noventa-bc's behalf after the user requested a Java draft PR following the TypeScript practices and approved diagram format.

Copy link
Copy Markdown
Collaborator Author

Shared implementation dependencies

Here, A → B means “A depends on B.” Preparation runs separately in each consuming job.

flowchart TD
  G["sdk_generation.yaml"] --> GL["speakeasy_generate.yaml"]
  P["sdk_publish.yaml"] --> PL["speakeasy_publish.yaml"]
  GL --> D["Patched Docker action<br/>Verified CLI 1.805.0"]
  PL --> D

  D --> SOURCE["Prepared action source<br/>.speakeasy/temp/action"]
  T["speakeasy_action_test.yaml<br/>Go, Python and real-artifact checks"] --> SOURCE

  SOURCE --> PREP["Shared preparation action<br/>.github/actions/prepare-speakeasy"]
  PREP --> UPSTREAM["Exact upstream action<br/>SHA 6eb2c860"]
  PREP --> PATCH["Our maintained runtime.patch"]
  PREP --> INPUTS["Copied build inputs<br/>pinned-cli.json + install_pinned_cli.py"]
Loading

Docker installation and embedded Go verification use the same copied pin. For a CLI bump, update_cli.py X.Y.Z updates only that JSON file; the source revision and runtime patch stay fixed. CI verifies the committed hashes against the real artifact without refreshing them. Synthetic test versions remain fixed.

The Publish implementation uses the Docker action for release and reporting callbacks. Gradle performs the registry upload through the existing legacy or Central publishing step. Java Smoke Test exercises the SDK independently of preparation.

The two upstream SHAs refer to different layers: the pinned reusable workflow sdk-publish.yaml@6f65a213 itself checks out action source 6eb2c860 for Java publication. The local implementation preserves that runtime revision and patches it before use. Java also declares the existing use_sonatype_legacy runtime output so the local workflow can retain the same legacy/Central gate.

🤖 Posted by Codex on noventa-bc's behalf after the user requested a Java draft PR following the TypeScript practices and approved diagram format.

Co-authored-by: Codex <noreply@openai.com>
@noventa-bc
noventa-bc requested a review from mtwalves November 10, 2026 14:30
@noventa-bc
noventa-bc marked this pull request as ready for review November 10, 2026 14:30
@noventa-bc
noventa-bc requested a review from a team as a code owner November 10, 2026 14:30
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T14:32:16.697164Z 4a72eef Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@noventa-bc
noventa-bc merged commit 82eb911 into main Nov 11, 2026
5 checks passed
@noventa-bc
noventa-bc deleted the noventa-bc/vm-19444-verified-cli-1.805.0 branch November 11, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants