Skip to content

Make test runner code compile using '-Werror=unused-parameter' - #844

Merged
mvandervoord merged 2 commits into
ThrowTheSwitch:masterfrom
swaldhoer:patch-1
Aug 24, 2026
Merged

Make test runner code compile using '-Werror=unused-parameter'#844
mvandervoord merged 2 commits into
ThrowTheSwitch:masterfrom
swaldhoer:patch-1

Conversation

@swaldhoer

Copy link
Copy Markdown
Contributor

No description provided.

@mvandervoord

Copy link
Copy Markdown
Member

Hi @swaldhoer -- whenever possible, I like to use the non-toolchain-specific solution to problems. If instead of using a gcc-specific pragma, you tried doing the (void)variable_name; trick for these variables, does that remove the problem on your toolchain? If so, I'd much prefer to use that, because it will fix it elsewhere also. Otherwise, we'll need to wrap this in #ifdefs for checking to see that it's gcc.

@swaldhoer

Copy link
Copy Markdown
Contributor Author

Yes that works equally well, I'll update the PR later

@mvandervoord

Copy link
Copy Markdown
Member

Thanks, you're awesome! :)

@mvandervoord
mvandervoord merged commit e48e25e into ThrowTheSwitch:master Aug 24, 2026
4 checks passed
@swaldhoer
swaldhoer deleted the patch-1 branch August 25, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants