Skip to content

fix: raise ValueError in encode() for non-lowercase input #14936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cclauss merged 8 commits into from
Jul 31, 2026
+15 −1
Merged

fix: raise ValueError in encode() for non-lowercase input #14936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3e23055
fix: raise ValueError in encode() for non-lowercase input
alisatwat3 Jul 14, 2026
9ff2a0b
resolved doctest
alisatwat3 Jul 14, 2026
9e795e4
Merge branch 'master' into issues/14931-ciphers-validate-lowercase-input
alisatwat3 Jul 29, 2026
8b25d9f
Fix Ruff 0.16 lint failures
alisatwat3 Jul 30, 2026
c5e7c78
Merge branch 'master' into issues/14931-ciphers-validate-lowercase-input
alisatwat3 Jul 31, 2026
a47679a
Enhance encode function error handling examples
cclauss Jul 31, 2026
459efc3
Fix indentation in test_cancer_data function
cclauss Jul 31, 2026
b639ac6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ciphers/a1z26.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,21 @@ def encode(plain: str) -> list[int]:
"""
>>> encode("myname")
[13, 25, 14, 1, 13, 5]
>>> encode("abCd")
Traceback (most recent call last):
...
ValueError: plain must contain only lowercase letters (a-z)
>>> encode("n0w")
Traceback (most recent call last):
...
ValueError: plain must contain only lowercase letters (a-z)
>>> encode("later!")
Traceback (most recent call last):
...
ValueError: plain must contain only lowercase letters (a-z)
"""
if not plain.islower() or not plain.isalpha():
raise ValueError("plain must contain only lowercase letters (a-z)")
return [ord(elem) - 96 for elem in plain]


Expand Down
2 changes: 1 addition & 1 deletion machine_learning/sequential_minimum_optimization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ def test_cancer_data():
print("Hello!\nStart test SVM using the SMO algorithm!")
# 0: download dataset and load into pandas' dataframe
if not os.path.exists(r"cancer_data.csv"):
request = urllib.request.Request( # noqa: S310
request = urllib.request.Request(
CANCER_DATASET_URL,
headers={"User-Agent": "Mozilla/4.0 (compatible; MSIE 5.5; Windows NT)"},
)
Expand Down