Conversation
Isolate harness path tests from host environment settings and verify Windows defaults. Cover real historical LF/CRLF fixtures, custom intent, local edits, reference collisions, and exact checksum baselines.
iuyo5678
marked this pull request as ready for review
September 21, 2026 13:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BrowserSkill previously loaded long skill bodies and maintained overlapping CLI instructions at the repository root and inside the crate. This change keeps exactly two authored skill packages and loads detailed procedures from references only when needed.
crates/bsk-cli/skill/the sole CLI source and keep the DSH source in its existing package. Reduce the entry points by 65% and 50%, respectively, while retaining prompt-injection rules in both entry points and preservingAGENT_INSTALL.md.SKILL.mdis missing, and validates pending old/new states before retrying an interrupted install. Conflicts preserve content and identify paths; explicit force replaces package targets while preserving unrelated user files. Existing single-file--sourceusage, including explicit symbolic links, remains supported alongside directory sources. Links inside packages and installed resources remain rejected.&.Validation:
cargo test --workspace --locked: 749 passed, 1 ignored on macOS.cargo clippy --workspace --all-targets --locked -- -D warningsand Rust formatting passed.Local validation ran on macOS. All eight checks on commit
dc80625passed, including the dedicated Windows DSH build/npm archive/runtime resource check (with spaces and&in temporary paths), Windows skill installation/migration, Node metadata/resource/Cargo checks, updates, cancellation, PowerShell 5.1 and PowerShell 7 installers, and the independent Windows daemon lifecycle job: https://github.com/Tencent/BrowserSkill/actions/runs/35607591094.Validation scope: these tests cover installation, recovery, metadata and package/runtime resource resolution. No real-model CLI/DSH task comparison has been run for reference-read timing, completion rate or token usage; those metrics require a configured harness and model evaluation environment.