Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/review-source-pathspec-order.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/intent': patch
---

Match a skill source in `review` when its path is nested. Git dropped the matches when the source came before the `node_modules` exclude, so a valid source reported no available files.
2 changes: 1 addition & 1 deletion packages/intent/src/review/review.ts
Original file line number Diff line number Diff line change
Expand Up @@ -404,8 +404,8 @@ export function createReview(cwd: string, baseRef?: string): ReviewReport {
'--exclude-standard',
'-z',
'--',
...patterns,
dependencyExclude,
...patterns,
]),
)
const diff = (patterns: Array<string> = [], from = base) =>
Expand Down
14 changes: 14 additions & 0 deletions packages/intent/tests/review.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,20 @@ it('excludes installed dependencies even without a gitignore entry', () => {
])
})

it('matches a single nested source while excluding installed dependencies', () => {
write('packages/client/src/index.ts', 'export const client = true\n')
write('packages/client/src/node_modules/installed/index.ts', 'dependency\n')
skill(['acme/library:packages/client/src/**'])
git('add', '.')
git('commit', '-qm', 'nested source')
const [item] = createReview(root).items
expect(item?.problems).toEqual([])
expect(Object.keys(item?.snapshot ?? {})).toEqual([
'packages/client/src/index.ts',
'skills/request/SKILL.md',
])
})

it('includes staged, unstaged, untracked and deleted paths and uses Git glob semantics', () => {
accept()
write('src/nested/more.ts', 'new source\n')
Expand Down
Loading