Repository navigation
Conversation
alejoe91
approved these changes
Oct 19, 2026
Member
|
This is great - thanks @h-mayorquin ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
InterpolateMotionRecording(whatcorrect_motionreturns) andSilencedPeriodsRecordingJSON-serializable, so chains that include them no longer have to be saved as pickles. Writing them to JSON already worked, but they could not be reloaded.I looked into the git history and found no rationale for making them pickle-only. The motion opt-out was added in #3341 as a temporary fix for #3313, and the silence periods one in #4539 without discussion. I am doing this now because of the zarr v3 support in #4260: making these recordings JSON-serializable will make that transition easier, see my review there (#4260 (review)).