Skip to content

Fix editData in HTML/UWP extensions allocating too much data #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SortaCore merged 2 commits into from
Jun 13, 2026
+86 −63
Merged

Fix editData in HTML/UWP extensions allocating too much data #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c9d638
Fix editData in HTML/UWP extensions not subtracting the eHeader and t…
AITYunivers Apr 30, 2026
74ce012
DarkEdif: Fix up HTML5/UWP prop handling
SortaCore May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DarkEdif/Bluewing Client/HTML5/Bluewing_Client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ globalThis['darkEdif'] = (globalThis['darkEdif'] && globalThis['darkEdif'].sdkVe
this.numProps = headerDV.getUint16(4 + 4 + 4, true); // Skip past hash and hashTypes
this.sizeBytes = headerDV.getUint32(4 + 4 + 4 + 4, true); // skip past numProps and pad

let editData = edPtrFile.readBuffer(this.sizeBytes - header.byteLength);
let editData = edPtrFile.readBuffer(this.sizeBytes - ext.ho.privateData - header.byteLength);
this.chkboxes = editData.slice(0, Math.ceil(this.numProps / 8));
let that = this;
let GetPropertyIndex = function(chkIDOrName) {
Expand Down
2 changes: 1 addition & 1 deletion DarkEdif/Bluewing Client/Wua/js/runtime/extensions/source/Bluewing_Client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ window['darkEdif'] = (window['darkEdif'] && window['darkEdif'].sdkVersion >= 19)
this.numProps = headerDV.getUint16(4 + 4 + 4, true); // Skip past hash and hashTypes
this.sizeBytes = headerDV.getUint32(4 + 4 + 4 + 4, true); // skip past numProps and pad

let editData = edPtrFile.readBuffer(this.sizeBytes - header.byteLength);
let editData = edPtrFile.readBuffer(this.sizeBytes - ext.ho.privateData - header.byteLength);
this.chkboxes = editData.slice(0, Math.ceil(this.numProps / 8));
let that = this;
let GetPropertyIndex = function(chkIDOrName) {
Expand Down
71 changes: 41 additions & 30 deletions DarkEdif/DarkEdif Template/HTML5/DarkEdif_Template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,53 +77,59 @@ globalThis['darkEdif'] = (globalThis['darkEdif'] && globalThis['darkEdif'].sdkVe

this['Properties'] = function(ext, edPtrFile, extVersion) {
// DarkEdif SDK stores offset of DarkEdif props away from start of EDITDATA inside private data.
// eHeader is 20 bytes, so this should be 20+ bytes.
// eHeader is 20 bytes, so privateData should be 20+ bytes.
// Note that edPtrFile points right after eHeader, not before.
if (ext.ho.privateData < 20) {
throw "Not smart properties - eHeader missing?";
// edPtrFile should point just after eHeader. If you read from edPtrFile
// before calling Properties ctor, edPtrFile.pointer will be moved, making it incorrect.
throw "Not smart properties - eHeader missing or file pointer incorrect?";
}
// DarkEdif SDK header read:
// header uint32, hash uint32, hashtypes uint32, numprops uint16, pad uint16, sizeBytes uint32 (includes whole EDITDATA)
// if prop set v2, then uint64 editor checkbox ptr
// then checkbox list, one bit per checkbox, including non-checkbox properties
// so skip numProps / 8 bytes
// then moving to Data list:
// size uint32 (includes whole Data), propType uint16, propNameSize uint8, propname u8 (lowercased), then data bytes

let bytes = edPtrFile.ccfBytes.slice(edPtrFile.pointer);
// Skip data between eHeader and Props. Note edPtrFile points right after eHeader.
edPtrFile.skipBytes(ext.ho.privateData - 20);

edPtrFile.skipBytes(ext.ho.privateData - 20); // sub size of eHeader; edPtrFile won't start with eHeader
const verBuff = new Uint8Array(edPtrFile.readBuffer(4));
const verStr = String.fromCharCode.apply('', verBuff.reverse());
// Read DarkEdif SDK header:
// header version uint32, hash uint32, hashtypes uint32, numprops uint16, pad uint16, sizeBytes uint32
// if prop set v2, then uint64 editor checkbox ptr
// Note sizeBytes includes whole EDITDATA.
const verStr = String.fromCharCode.apply('', (new Uint8Array(edPtrFile.readBuffer(4))).reverse());
let propVer;
if (verStr == 'DAR2') {
propVer = 2;
} else if (verStr == 'DAR1') {
propVer = 1;
} else {
throw "Version string " + verStr + " unknown. Did you restore the file offset?";
// edPtrFile should point right after eHeader. If you read from edPtrFile
// before calling Properties ctor, edPtrFile.pointer will be moved, making it incorrect.
throw "Version string " + verStr + " unknown. Did you not restore the file offset before Properties ctor?";
}
// Pull out hash, hashTypes, numProps, pad, sizeBytes, visibleEditorProps
let header = new Uint8Array(edPtrFile.readBuffer(4 + 4 + 2 + 2 + 4 + (propVer > 1 ? 8 : 0)));
let headerDV = new DataView(header.buffer);
const header = new Uint8Array(edPtrFile.readBuffer(4 + 4 + 2 + 2 + 4 + (propVer > 1 ? 8 : 0)));
const headerDV = new DataView(header.buffer);
this.numProps = headerDV.getUint16(4 + 4, true); // Skip past hash and hashTypes
this.sizeBytes = headerDV.getUint32(4 + 4 + 4, true); // skip past numProps and pad

// sizeBytes includes the whole EDITDATA
this.sizeBytes = headerDV.getUint32(4 + 4 + 2 + 2, true); // skip past hash, hashTypes, numProps, pad

let editData = edPtrFile.readBuffer(
// Read past the DarkEdif Props header
const editData = edPtrFile.readBuffer(
this.sizeBytes -
// skip area between eHeader -> Props
(ext.ho.privateData - 20) -
// Skip DarkEdif header
header.byteLength
// skip eHeader to Props
ext.ho.privateData -
// Skip verStr and the rest of DarkEdif Props header we already read
(4 + header.byteLength)
);

// After the header, the data starts with checkbox list, one bit per checkbox,
// including non-checkbox properties, so read numProps / 8 bytes for that.
this.chkboxes = editData.slice(0, Math.ceil(this.numProps / 8));
let that = this;
let IsComboBoxProp = function(propTypeID) {
const IsComboBoxProp = function(propTypeID) {
// PROPTYPE_COMBOBOX, PROPTYPE_COMBOBOXBTN, PROPTYPE_ICONCOMBOBOX
return propTypeID == 7 || propTypeID == 20 || propTypeID == 24;
};
let RuntimePropSet = function(data) {
let rsDV = new DataView(data.propData.buffer);
let rs = /* RuntimePropSet */ {
const RuntimePropSet = function(data) {
const rsDV = new DataView(data.propData.buffer);
const rs = /* RuntimePropSet */ {
// Always 'S', compared with 'L' for non-set list.
setIndicator: String.fromCharCode(rsDV.getUint8(0)),
// Number of repeats of this set, 1 is minimum and means one of this set
Expand All @@ -148,7 +154,7 @@ globalThis['darkEdif'] = (globalThis['darkEdif'] && globalThis['darkEdif'].sdkVe
throw "Not a prop set!";
return rs;
};
let GetPropertyIndex = function(chkIDOrName) {
const GetPropertyIndex = function(chkIDOrName) {
if (propVer > 1) {
let jsonIdx = -1;
if (typeof chkIDOrName == 'number') {
Expand Down Expand Up @@ -368,15 +374,20 @@ globalThis['darkEdif'] = (globalThis['darkEdif'] && globalThis['darkEdif'].sdkVe
throw "No set found with name " + setName + ".";
}

// Then moving to Data stream:
// sizeBytes uint32, propType uint16, [propJSONIndex uint16 - v2 only], propNameSize uint8,
// propName u8 (lowercased), data u8 (sizeBytes - propNameSize bytes)
// then next Data starts.
// v1 has combo list properties data as text; v2 has a starter S for prop set, L for list.
// Format hexpat is available.
this.props = [];
const data = editData.slice(this.chkboxes.length);
const dataDV = new DataView(new Uint8Array(data).buffer);

this.textDecoder = null;
if (globalThis['TextDecoder'] != null) {
this.textDecoder = new globalThis['TextDecoder']();
}
else {
} else {
// one byte = one char - should suffice for basic ASCII property names
this.textDecoder = {
decode: function(txt) {
Expand Down
70 changes: 41 additions & 29 deletions DarkEdif/DarkEdif Template/Wua/js/runtime/extensions/source/DarkEdif_Template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,53 +80,59 @@ window['darkEdif'] = (window['darkEdif'] && window['darkEdif'].sdkVersion >= 20)

this['Properties'] = function(ext, edPtrFile, extVersion) {
// DarkEdif SDK stores offset of DarkEdif props away from start of EDITDATA inside private data.
// eHeader is 20 bytes, so this should be 20+ bytes.
// eHeader is 20 bytes, so privateData should be 20+ bytes.
// Note that edPtrFile points right after eHeader, not before.
if (ext.ho.privateData < 20) {
throw "Not smart properties - eHeader missing?";
// edPtrFile should point just after eHeader. If you read from edPtrFile
// before calling Properties ctor, edPtrFile.pointer will be moved, making it incorrect.
throw "Not smart properties - eHeader missing or file pointer incorrect?";
}
// DarkEdif SDK header read:
// header uint32, hash uint32, hashtypes uint32, numprops uint16, pad uint16, sizeBytes uint32 (includes whole EDITDATA)
// if prop set v2, then uint64 editor checkbox ptr
// then checkbox list, one bit per checkbox, including non-checkbox properties
// so skip numProps / 8 bytes
// then moving to Data list:
// size uint32 (includes whole Data), propType uint16, propNameSize uint8, propname u8 (lowercased), then data bytes

let bytes = edPtrFile.ccfBytes.slice(edPtrFile.pointer);
// Skip data between eHeader and Props. Note edPtrFile points right after eHeader.
edPtrFile.skipBytes(ext.ho.privateData - 20);

edPtrFile.skipBytes(ext.ho.privateData - 20); // sub size of eHeader; edPtrFile won't start with eHeader
const verBuff = new Uint8Array(edPtrFile.readBuffer(4));
const verStr = String.fromCharCode.apply('', verBuff.reverse());
// Read DarkEdif SDK header:
// header version uint32, hash uint32, hashtypes uint32, numprops uint16, pad uint16, sizeBytes uint32
// if prop set v2, then uint64 editor checkbox ptr
// Note sizeBytes includes whole EDITDATA.
const verStr = String.fromCharCode.apply('', (new Uint8Array(edPtrFile.readBuffer(4))).reverse());
let propVer;
if (verStr == 'DAR2') {
propVer = 2;
} else if (verStr == 'DAR1') {
propVer = 1;
} else {
throw "Version string " + verStr + " unknown. Did you restore the file offset?";
// edPtrFile should point right after eHeader. If you read from edPtrFile
// before calling Properties ctor, edPtrFile.pointer will be moved, making it incorrect.
throw "Version string " + verStr + " unknown. Did you not restore the file offset before Properties ctor?";
}
// Pull out hash, hashTypes, numProps, pad, sizeBytes, visibleEditorProps
let header = new Uint8Array(edPtrFile.readBuffer(4 + 4 + 2 + 2 + 4 + (propVer > 1 ? 8 : 0)));
let headerDV = new DataView(header.buffer);
// Read hash, hashTypes, numProps, pad, sizeBytes, visibleEditorProps
const header = new Uint8Array(edPtrFile.readBuffer(4 + 4 + 2 + 2 + 4 + (propVer > 1 ? 8 : 0)));
const headerDV = new DataView(header.buffer);
this.numProps = headerDV.getUint16(4 + 4, true); // Skip past hash and hashTypes
this.sizeBytes = headerDV.getUint32(4 + 4 + 4, true); // skip past numProps and pad

// sizeBytes includes the whole EDITDATA
this.sizeBytes = headerDV.getUint32(4 + 4 + 2 + 2, true); // skip past hash, hashTypes, numProps, pad

let editData = edPtrFile.readBuffer(
// Read past the DarkEdif Props header
const editData = edPtrFile.readBuffer(
this.sizeBytes -
// skip area between eHeader -> Props
(ext.ho.privateData - 20) -
// Skip DarkEdif header
header.byteLength
// skip eHeader to Props
ext.ho.privateData -
// Skip verStr and the rest of DarkEdif Props header we already read
(4 + header.byteLength)
);

// After the header, the data starts with checkbox list, one bit per checkbox,
// including non-checkbox properties, so read numProps / 8 bytes for that.
this.chkboxes = editData.slice(0, Math.ceil(this.numProps / 8));
let that = this;
let IsComboBoxProp = function(propTypeID) {
const IsComboBoxProp = function(propTypeID) {
// PROPTYPE_COMBOBOX, PROPTYPE_COMBOBOXBTN, PROPTYPE_ICONCOMBOBOX
return propTypeID == 7 || propTypeID == 20 || propTypeID == 24;
};
let RuntimePropSet = function(data) {
let rsDV = new DataView(data.propData.buffer);
let rs = /* RuntimePropSet */ {
const RuntimePropSet = function(data) {
const rsDV = new DataView(data.propData.buffer);
const rs = /* RuntimePropSet */ {
// Always 'S', compared with 'L' for non-set list.
setIndicator: String.fromCharCode(rsDV.getUint8(0)),
// Number of repeats of this set, 1 is minimum and means one of this set
Expand All @@ -151,7 +157,7 @@ window['darkEdif'] = (window['darkEdif'] && window['darkEdif'].sdkVersion >= 20)
throw "Not a prop set!";
return rs;
};
let GetPropertyIndex = function(chkIDOrName) {
const GetPropertyIndex = function(chkIDOrName) {
if (propVer > 1) {
let jsonIdx = -1;
if (typeof chkIDOrName == 'number') {
Expand Down Expand Up @@ -371,6 +377,12 @@ window['darkEdif'] = (window['darkEdif'] && window['darkEdif'].sdkVersion >= 20)
throw "No set found with name " + setName + ".";
}

// Then moving to Data stream:
// sizeBytes uint32, propType uint16, [propJSONIndex uint16 - v2 only], propNameSize uint8,
// propName u8 (lowercased), data u8 (sizeBytes - propNameSize bytes)
// then next Data starts.
// v1 has combo list properties data as text; v2 has a starter S for prop set, L for list.
// Format hexpat is available.
this.props = [];
const data = editData.slice(this.chkboxes.length);
const dataDV = new DataView(new Uint8Array(data).buffer);
Expand Down
2 changes: 1 addition & 1 deletion DarkEdif/DarkScript/HTML5/DarkScript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ class DarkEdif {
this.numProps = headerDV.getUint16(4 + 4 + 4, true); // Skip past hash and hashTypes
this.sizeBytes = headerDV.getUint32(4 + 4 + 4 + 4, true); // skip past numProps and pad

let editData = edPtrFile.readBuffer(this.sizeBytes - header.byteLength);
let editData = edPtrFile.readBuffer(this.sizeBytes - ext.ho.privateData - header.byteLength);
this.chkboxes = editData.slice(0, Math.ceil(this.numProps / 8));
let that = this;
let GetPropertyIndex = function (chkIDOrName) {
Expand Down
2 changes: 1 addition & 1 deletion DarkEdif/DarkScript/Wua/js/runtime/extensions/source/DarkScript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ window['darkEdif'] = (window['darkEdif'] && window['darkEdif'].sdkVersion >= 19)
this.numProps = headerDV.getUint16(4 + 4 + 4, true); // Skip past hash and hashTypes
this.sizeBytes = headerDV.getUint32(4 + 4 + 4 + 4, true); // skip past numProps and pad

let editData = edPtrFile.readBuffer(this.sizeBytes - header.byteLength);
let editData = edPtrFile.readBuffer(this.sizeBytes - ext.ho.privateData - header.byteLength);
this.chkboxes = editData.slice(0, Math.ceil(this.numProps / 8));
let that = this;
let GetPropertyIndex = function(chkIDOrName) {
Expand Down