Events Migration (Inventory Events)#8765
Open
AnOwlBe wants to merge 1 commit into
Open
Conversation
AnOwlBe
requested review from
TheMug06,
UnderscoreTud and
cheeezburga
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This is part 5 of probably 6-8 more prs needed to migrate all of simpleevents & njol/skript/events into the skriptlang folder in their related module while (hopefully) preventing any breaking changes.
Solution
Creates an
inventoryfolder inorg.skriptlang.skript.bukkitimplements an InventoryModule (bare bones for now but in the future when more inventory elements are migrated it'll probably get pretty big)also moves InventoryClassInfo into the inventory folder
and uh yeah migrates the below events
progress:
Testing Completed
quicktest ran successfully junit did not (due to version mismatch so will have to rely on githubs junit tests) also manual testing completed for each event all appear to work fine
for those who want to test:
inventoryevents.txt
Supporting Information
null
Completes: none
Related: all the other event migration prs
AI assistance: none