Skip to content

fix: Update totalSamples calculation to account for bytes per sample#494

Open
vasu-nageshri wants to merge 1 commit into
mainfrom
fix/recorder-current-duration-doubled
Open

fix: Update totalSamples calculation to account for bytes per sample#494
vasu-nageshri wants to merge 1 commit into
mainfrom
fix/recorder-current-duration-doubled

Conversation

@vasu-nageshri

Copy link
Copy Markdown
Contributor

Description

Before:

Screen_recording_20260618_161103.mp4

After:

Screen_recording_20260618_160935.mp4

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #491

@vasu-nageshri vasu-nageshri force-pushed the fix/recorder-current-duration-doubled branch from b93e36a to 6c52454 Compare June 18, 2026 10:49
@vasu-nageshri vasu-nageshri changed the base branch from feat/swift-package-manager-support to main June 18, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: RecorderController.onCurrentDuration is twice the real duration

1 participant