Fix analytics metadata for app/theme#7765
Open
gonzaloriestra wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260609114645Caution After installing, validate the version by running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Related thread: https://shopify.slack.com/archives/C05E3BDFDRB/p1780923031432789
In #7010 we changed the way to load files, and the analytics metadata we add for app or theme commands is not being included.
The bundled CLI was loading app/theme code through two different module graphs: command entrypoints were bundled from source files, while package imports and hooks resolved through built
distfiles. That meant in-memory metadata could be recorded in one module instance and read from another, so app command analytics could miss app-specific fields.WHAT is this pull request doing?
../app/distand../theme/distinstead of source files, so command imports and package imports share the same module graph.How to test your changes?
shopify app deploy --verboseChecklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add