Conversation
from_json() received a plain Python string already decoded from JSON — OData
JSON responses never wrap Edm.String values in single quotes, so the strip was
wrong and silently truncated values that legitimately begin or end with "'".
Return the value unchanged instead.
from_literal() receives an OData URI literal of the form 'value' and must
remove exactly one wrapping pair. Replace strip("'") with a guarded slice
(value[1:-1]) that fires only when both ends carry a quote, leaving inner
leading/trailing quotes intact.
Existing unit tests were enhanced to fill test gaps.
Two pre-existing tests were also corrected: they passed OData-literal-wrapped
strings (e.g. "'x'") as from_json input, which only passed because the buggy
strip silently unwrapped them. Real JSON payloads carry bare string values;
the test data has been updated to reflect that.
Closes #295
filak-sap
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from_json() received a plain Python string already decoded from JSON — OData JSON responses never wrap Edm.String values in single quotes, so the strip was wrong and silently truncated values that legitimately begin or end with "'". Return the value unchanged instead.
from_literal() receives an OData URI literal of the form 'value' and must remove exactly one wrapping pair. Replace strip("'") with a guarded slice (value[1:-1]) that fires only when both ends carry a quote, leaving inner leading/trailing quotes intact.
Existing unit tests were enhanced to fill test gaps.
Two pre-existing tests were also corrected: they passed OData-literal-wrapped strings (e.g. "'x'") as from_json input, which only passed because the buggy strip silently unwrapped them. Real JSON payloads carry bare string values; the test data has been updated to reflect that.
Closes #295