Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Topic that both subscribes and advertises overwrites its one saved connection message and registers duplicate close hooks. Reconnection restores only the last role; removing either role can also remove reconnection for the remaining role. This addresses the dual-role reconnect behavior described in #114.
Track active connection messages by operation and register one close hook per topic. Remove only the cancelled role and replay the roles still active when the delayed reconnect runs. Regressions cover both role orders, hook registration, removing either role and cancelling both while reconnect is pending.
Validation: Four regression cases fail on the base revision and all 5 pass after the fix. With existing transport/header tests, Twisted passes 9 tests (3 skipped) and asyncio passes 11 tests (1 skipped). No live ROS bridge or robot was used.
AI-assisted implementation and tests; the failures and passing results above were reproduced locally.