Skip to content

fix(deps): update all dependencies - #1791

Merged
bsquizz merged 3 commits into
masterfrom
konflux/mintmaker/master/all
Aug 31, 2026
Merged

fix(deps): update all dependencies#1791
bsquizz merged 3 commits into
masterfrom
konflux/mintmaker/master/all

Conversation

@red-hat-konflux

@red-hat-konflux red-hat-konflux Bot commented Jun 25, 2026 •
edited by bsquizz
Loading

Copy link
Copy Markdown
Contributor

Note

This PR was originally generated by Renovate to update all dependencies, but required manual fixes to resolve build and lint failures.

Summary

  • Updates Go dependencies (actions, indirect deps, base images) as proposed by Renovate/Mintmaker
  • Fixes .golangci.yml to use valid golangci-lint v2 configuration format
  • Fixes dependency version conflicts that prevented compilation

Dependency conflict fixes

The Renovate-generated go.mod had several issues that broke the build:

  1. github.com/google/cel-go v0.32.0 — this version was published under a new module path (cel.dev/cel-go), so Go couldn't resolve it at the old path. Excluded v0.29.0 (which has breaking API changes for caddy) to resolve to v0.28.1.

  2. github.com/KimMachineGun/automemlimit v1.0.0 — renamed SetGoMemLimitWithOpts to Set, breaking caddy/v2@v2.11.4. Excluded v1.0.0 to resolve to v0.7.5.

  3. sigs.k8s.io/cluster-api/api — upstream uses a local-path replace directive that doesn't work as a transitive dependency. Added an explicit replace pointing to the published api/v1.14.0 sub-module.

  4. k8s.io/api version drift — MVS bumped k8s.io/api to v0.36.3, which removed packages (autoscaling/v2beta1, scheduling/v1alpha1) still imported by the pinned client-go@v0.35.6. Added replace directives to keep all k8s.io packages at v0.35.6.

  5. Duplicate entries in go.mod — cespare/xxhash/v2, dgraph-io/badger/v4, go-jose/go-jose/v4, and go.yaml.in/yaml/v3 each appeared twice.

  6. Missing go.sum entries — original commit updated go.mod but didn't regenerate go.sum.

.golangci.yml fixes

Updated to valid golangci-lint v2 format:

  • Restored version: "2" (required by v2)
  • Moved gofmt/goimports under formatters.enable (v2 treats them as formatters, not linters)
  • Moved staticcheck settings under linters.settings (not top-level linters-settings)
  • Removed invalid output.formats.text section

Test plan

  • go build ./... compiles successfully
  • CI lint check passes
  • CI unit tests pass

🤖 Generated with Claude Code

@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/master/all branch 24 times, most recently from 911ac8f to f8b995e Compare July 2, 2026 05:22
@red-hat-konflux

red-hat-konflux Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

ℹ️ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 2 additional dependencies were updated
  • The go directive was updated for compatibility reasons

Details:

Package Change
go 1.25.9 -> 1.26.0
k8s.io/apimachinery v0.35.6 -> v0.36.2
google.golang.org/protobuf v1.36.11 -> v1.36.12-0.20260120151049-f2248ac996af

@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/master/all branch 5 times, most recently from 3294628 to 068352a Compare July 3, 2026 09:16
@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/master/all branch 17 times, most recently from 34fed82 to 3442808 Compare July 10, 2026 13:15
@red-hat-konflux

red-hat-konflux Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: go.sum
Command failed: go get -t ./...
go: github.com/google/cel-go@v0.32.0: parsing go.mod:
	module declares its path as: cel.dev/cel-go
	        but was required as: github.com/google/cel-go

@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/master/all branch 5 times, most recently from 278a903 to 78209e4 Compare July 11, 2026 10:36
@bsquizz

bsquizz commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

/retest

red-hat-konflux Bot and others added 3 commits August 31, 2026 15:52
@red-hat-konflux @bsquizz
fix(deps): update all dependencies
9bcf38c 
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@bsquizz @claude
fix: resolve lint failures from invalid config and missing go.sum
fe8afa4 
Fixes three issues introduced in commit 9bcf38c that broke CI lint checks:

1. Invalid .golangci.yml configuration format:
   - Added version: "2" required by golangci-lint v2 (CI uses v2.13.2)
   - Removed invalid `formatters` section (not supported in golangci-lint v2)
   - Fixed `linters.settings` → `linters-settings`
   - Moved gofmt/goimports to linters.enable (v2 treats them as linters)
   - Removed output.formats section (optional and was causing errors)

2. Invalid cel-go module version:
   - Commit 9bcf38c specified github.com/google/cel-go@v0.32.0
   - This version doesn't exist at that path (moved to cel.dev/cel-go)
   - Caused module path mismatch errors
   - Downgraded to v0.29.0 which uses the old import path

3. Missing go.sum entries:
   - Commit 9bcf38c updated go.mod but didn't regenerate go.sum
   - Ran \`go mod tidy\` to properly regenerate checksums

These changes allow golangci-lint v2 to run successfully in CI.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@bsquizz @claude
fix: resolve dependency conflicts preventing build and lint
b9a2f14 
The Renovate-generated go.mod had several dependency conflicts:

1. cel-go v0.32.0 at github.com/google/cel-go path doesn't exist
   (moved to cel.dev/cel-go) — caused go mod download failures
2. automemlimit v1.0.0 removed SetGoMemLimitWithOpts (renamed to Set),
   breaking caddy v2.11.4 which calls the old API
3. cel-go v0.29.0 changed NewCall to take []InterpretableV2 instead of
   []Interpretable, breaking caddy v2.11.4
4. cluster-api v1.14.0 uses a local replace for its /api submodule that
   doesn't resolve as a transitive dependency
5. k8s.io/api version must stay at v0.35.6 to match pinned client-go
6. Duplicate entries and missing go.sum

Fixed with exclude directives for incompatible versions, replace
directives for k8s.io packages and cluster-api/api, and go mod tidy
to regenerate a consistent go.sum.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@bsquizz

bsquizz commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

/test-e2e

ffeghali
ffeghali approved these changes Aug 31, 2026
View reviewed changes

@ffeghali ffeghali left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsquizz bsquizz bsquizz approved these changes
@ffeghali ffeghali ffeghali approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bsquizz @ffeghali