Repository navigation
4.x: Isolate Maybe zip race tests - #8320
Merged
Merged
Conversation
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.855 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.x #8320 +/- ##
============================================
+ Coverage 98.61% 98.66% +0.04%
+ Complexity 7155 7154 -1
============================================
Files 824 824
Lines 50822 50822
Branches 6920 6920
============================================
+ Hits 50120 50143 +23
+ Misses 476 465 -11
+ Partials 226 214 -12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
akarnokd
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #8075.
Move the existing
innerErrorRacetest from bothMaybeZipArrayTestandMaybeZipIterableTestinto their corresponding@Isolatedclasses, following the naming requested in #8075.Both test methods retain their original bodies, loop counts, assertions, and plugin cleanup. The
addStringhelpers remain available to the ordinary tests and are copied into the new classes. This change contains only test movements.Local verification on Temurin 26.0.2.1+1 and Gradle 9.8.0, using cached dependencies in offline mode:
announcecases were skipped (2 before, 4 after).checkstyleTestpassed.This prepares these tests for JUnit isolation when parallel execution is enabled. The current build does not enable JUnit parallel execution, and
@Isolateddoes not coordinate separate Gradle test JVMs.AI disclosure: OpenAI Codex was used to prepare the changes, run the local checks, and draft this PR description.