Skip to content

reformat and realign function table - #7396

Merged
ben-schwen merged 5 commits into
masterfrom
jumpTableCastRemoval
Aug 6, 2026
Merged

reformat and realign function table#7396
ben-schwen merged 5 commits into
masterfrom
jumpTableCastRemoval

Conversation

@badasahog

Copy link
Copy Markdown
Contributor

Ignore the fork name.

Just reformatting to make it more readable.

@github-actions

github-actions Bot commented Oct 27, 2025

Copy link
Copy Markdown

No obvious timing issues in HEAD=jumpTableCastRemoval
Comparison Plot

Generated via commit 7aa8ab6

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 6 minutes and 50 seconds
Installing different package versions 13 minutes and 24 seconds
Running and plotting the test cases 6 minutes and 25 seconds

@codecov

codecov Bot commented Oct 27, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.01%. Comparing base (d63559f) to head (eb45785).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7396   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files          88       88           
  Lines       17293    17296    +3     
=======================================
+ Hits        17123    17126    +3     
  Misses        170      170           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/init.c Outdated
{ "Ctest_dt_win_snprintf", (DL_FUNC)&test_dt_win_snprintf, -1 },
{ "Cdt_zlib_version", (DL_FUNC)&dt_zlib_version, -1 },
{ "Cdt_has_zlib", (DL_FUNC)&dt_has_zlib, -1 },
{ "Csubstitute_call_arg_namesR", (DL_FUNC)&substitute_call_arg_namesR, -1 },

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice now, but if ever a new routine is added that is longer than Csubstitute_call_arg_namesR, it will induce a very large diff touching all of these lines.

So to complete this PR I would:

  • put static const ** on the first line
  • indent the array contents by 2 spaces

And remove extra whitespace.

There are a few packages doing { "..." instead of {"...", but it's the minority. Personally I prefer {"...".

@ben-schwen
ben-schwen merged commit 99142f3 into master Aug 6, 2026
3 of 4 checks passed
@ben-schwen
ben-schwen deleted the jumpTableCastRemoval branch August 6, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants