Project importer fixes#901
Merged
Merged
Conversation
Test coverage92.04% line coverage reported by SimpleCov. |
raspberrypiherokubot
temporarily deployed
to
editor-api-p-project-im-zhfcf7
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes UploadJob’s “build: false” handling so skipping one project does not inadvertently skip subsequent project imports within the same run (and adds regression coverage).
Changes:
- Remove the persistent
@skip_jobflag and instead skip import per-project whenproject_config.ymlsetsbuild: false. - Keep
format_projectlightweight for non-buildable projects by returning early from config parsing. - Add an RSpec regression test ensuring a later buildable project is still imported after an earlier
build: falseproject.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
app/jobs/upload_job.rb |
Eliminates cross-project state (@skip_job) and makes skipping depend only on the current project’s build flag. |
spec/jobs/upload_job_spec.rb |
Adds a multi-project regression spec to ensure build: false doesn’t prevent later projects from importing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
skip_jobvariable. Once@skip_jobwas set to true by a project withbuild: falsein itsproject_config.yml, it stayed true for the rest of the run, meaning every following project import for every locale would be skipped.