Importing projects site projects from .sb3 files#855
Conversation
Test coverage91.98% line coverage reported by SimpleCov. |
|
We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please complete this form and we'll get you added and review your contribution as soon as possible. |
rammodhvadia
changed the title
|
We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please complete this form and we'll get you added and review your contribution as soon as possible. |
| io.rewind if io.respond_to?(:rewind) | ||
| result = nil | ||
| Zip::File.open_buffer(io.read) { |zip_file| result = yield zip_file } | ||
| result |
There was a problem hiding this comment.
Is the rewind needed? Also you don't need to assign the result, but you can call return inside the block.
| io.rewind if io.respond_to?(:rewind) | |
| result = nil | |
| Zip::File.open_buffer(io.read) { |zip_file| result = yield zip_file } | |
| result | |
| Zip::File.open_buffer(io.read) do | |
| return yield it | |
| end |
|
We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please complete this form and we'll get you added and review your contribution as soon as possible. |
|
We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please complete this form and we'll get you added and review your contribution as soon as possible. |
|
We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please complete this form and we'll get you added and review your contribution as soon as possible. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please complete this form and we'll get you added and review your contribution as soon as possible. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7964582. Configure here.
|
We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please complete this form and we'll get you added and review your contribution as soon as possible. |
mwtrew
left a comment
mwtrew
left a comment
There was a problem hiding this comment.
Changes since Chris' review look fine to me.
What's changed?
.sb3filecode_editor_scratchprojects.sb3files.sb3files