fix: forward shadow block context menu to parent#10070
Open
mikeharv wants to merge 1 commit into
Open
Conversation
maribethb
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9999
Proposed Changes
BlockSvg.showContextMenuso shadow blocks forward to the nearest non-shadow ancestor instead of opening their own menu.Reason for Changes
Shadow blocks do not have context menus for mouse users, but keyboard users can still focus them and trigger one (e.g. Ctrl/Cmd+Enter). Forwarding to the owning block matches mouse/pointer behavior and exposes the parent’s relevant actions.
Test Coverage
Added a
Block showContextMenusuite incontextmenu_test.jscovering value-input shadow forwarding, nested input shadows, and a non-shadow regression case.