Skip to content

chore: use none ARIA role consistently instead of presentation#10067

Merged
mikeharv merged 2 commits into
RaspberryPiFoundation:mainfrom
dejoski:docs/issue-9993-use-none-role
Jun 25, 2026
Merged

chore: use none ARIA role consistently instead of presentation#10067
mikeharv merged 2 commits into
RaspberryPiFoundation:mainfrom
dejoski:docs/issue-9993-use-none-role

Conversation

@dejoski

@dejoski dejoski commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add aria.Role.NONE for the ARIA none role
  • replace internal uses of the presentation role with the none role
  • update role assertions in the affected mocha tests

Closes #9993

Validation

  • npm ci
  • npm run lint --workspace blockly
  • npm run tsc --workspace blockly
  • git diff --check

Signed-off-by: Dejan Stajic <8886210+dejoski@users.noreply.github.com>
@dejoski dejoski requested a review from a team as a code owner June 25, 2026 13:33
@dejoski dejoski requested a review from mikeharv June 25, 2026 13:33
@github-actions github-actions Bot added the PR: fix Fixes a bug label Jun 25, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

@mikeharv mikeharv changed the title fix: use none ARIA role consistently chore: use none ARIA role consistently instead of presentation Jun 25, 2026
@github-actions github-actions Bot added PR: chore General chores (dependencies, typos, etc) and removed PR: fix Fixes a bug labels Jun 25, 2026

@mikeharv mikeharv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up for us!

@mikeharv mikeharv merged commit 07c83d3 into RaspberryPiFoundation:main Jun 25, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: chore General chores (dependencies, typos, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

consistently use role of none instead of role of presentation

2 participants