feat!: make field-multilineinput keyboard navigable and accessible#2729
Merged
maribethb merged 7 commits intoJun 25, 2026
Merged
Conversation
gonfunko
reviewed
Jun 24, 2026
| * @returns The keycap element. | ||
| */ | ||
| private createHintKeycap(label: string): HTMLSpanElement { | ||
| const key = document.createElement('span'); |
| this.textarea.value = 'hello world'; | ||
| this.textarea.selectionStart = 5; | ||
| this.textarea.selectionEnd = 11; | ||
| this.field['insertNewline'](); |
Contributor
There was a problem hiding this comment.
Is this tortured syntax to get around it being private?
Contributor
Author
There was a problem hiding this comment.
lol yeah which tbh i prefer over the TEST_ONLY nonsense we sometimes do
gonfunko
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes field-multilineinput not keyboard accessible
Proposed Changes
Entercommit edits, like all other input fields (this is a breaking behavioral change).Shift+Enterhandler that adds newlines.Reason for Changes
This plugin couldn't be used with only the keyboard as there was no way to commit a change.
Test Coverage
Tested manually and added additional unit tests.
Documentation
updated the readme already
Additional Information