Conversation
`_sectors` returned `values(::Set)`, i.e. hash iteration order, which changed in Julia 1.13 and broke the two `sectors(V)` assertions in the SumSpace tests (they had codified 1.12's order). The order also leaks into fusion tree enumeration via `map(sectors, P)`, making the layout within a block depend on the Julia version. Sort the result instead, consistent with `sectors(::GradedSpace)` (sorted by construction) and `blocksectors(::ProductSpace)` (ends with `sort!`), and assert the invariant with `issorted` rather than a hardcoded permutation. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
`mul!` accumulates block contributions with `β = One()`, which reaches `LinearAlgebra` untouched. On Julia 1.13 the HERK path calls `isreal(β)`, which `VectorInterface.One` does not implement, so `w' * w` errors. Map `One`/`Zero` to `true`/`false` at that hand-off; the latter is exactly the strong zero `LinearAlgebra` documents, so the semantics are unchanged. The generic `_mul!!` fallbacks keep the `One`/`Zero` types for VectorInterface's promotion. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
lkdvos
changed the title
sectors(::SumSpace)
Member
Author
|
See also QuantumKitHub/VectorInterface.jl#54 for a "better" fix for the |
Merged
lkdvos
referenced
this pull request
Sep 11, 2026
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two Julia 1.13 fixes.
sectors(::SumSpace)ordering._sectorsreturnedvalues(::Set)— hash order. Julia 1.13 changed it, so the twosectors(V)assertions intest/vectorspaces/sumspace.jlfailed (they had codified 1.12's order; for U₁ that happened to be the sorted one). The order also reaches fusion tree enumeration throughmap(sectors, P). Sort instead, matchingsectors(::GradedSpace)andblocksectors(::ProductSpace), and assertissortedrather than a fixed permutation.One/Zeroscalars intoLinearAlgebra.mul!accumulates block contributions withβ = One(), which travels through_mul!!intoLinearAlgebra; 1.13's HERK path callsisreal(β), whichVectorInterface.Onedoes not implement, sow' * werrors. MapOne/Zerototrue/falseat that hand-off —falseis exactly the strong zeroLinearAlgebradocuments, so semantics are unchanged. MarkedTODOfor removal once VectorInterface covers theNumberinterface.Green on 1.12.6 (full suite) and on 1.13.0 (full suite).
🤖 Generated with Claude Code