Skip to content

fix(service-terraform): truncate long .tfvars file paths in popover - #2871

Merged
RemiBonnet merged 1 commit into
stagingfrom
fix/tfvars-popover-truncate-long-path
Aug 14, 2026
Merged

fix(service-terraform): truncate long .tfvars file paths in popover#2871
RemiBonnet merged 1 commit into
stagingfrom
fix/tfvars-popover-truncate-long-path

Conversation

@RemiBonnet

Copy link
Copy Markdown
Member

Summary

Issue:

Long .tfvars file paths in the "Add and order .tfvars files" popover were rendered without any truncation, so a long path overflowed its row, broke the grid layout and pushed the order input out of view.

Changes

  • Add min-w-0 to the row's flex container and label so flex/grid children can shrink below their content width.
  • Apply truncate to the file source path.
  • Wrap the path in a Tooltip so the full path is still readable on hover (consistent with the SourceCell pattern in terraform-variables-table).

Screenshots / Recordings

UI-only change; before/after to be attached by reviewer.

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test
  • yarn format
  • yarn lint

Note: automated checks could not be run in the agent environment (no Node/Yarn toolchain available). Please run yarn format && yarn lint && yarn test in CI/locally.

PR Checklist

  • Conventional Commit title with scope
  • Self-review performed, diff kept focused
  • Designer validation for UI change

@nx-cloud

nx-cloud Bot commented Aug 14, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 88a991e

Command Status Duration Result
nx run console:build --parallel=3 --configurati... ✅ Succeeded 2m 25s View ↗
nx affected --target=test --parallel=3 --config... ✅ Succeeded <1s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded <1s View ↗
nx-cloud record -- yarn nx format:check ✅ Succeeded 5s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-08-14 10:13:57 UTC

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.77%. Comparing base (d022841) to head (88a991e).

❗ There is a different number of reports uploaded between BASE (d022841) and HEAD (88a991e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d022841) HEAD (88a991e)
unittests 2 1
Additional details and impacted files
@@             Coverage Diff              @@
##           staging    #2871       +/-   ##
============================================
- Coverage    49.62%   34.77%   -14.86%     
============================================
  Files          851       55      -796     
  Lines        21218     1550    -19668     
  Branches      6381      514     -5867     
============================================
- Hits         10530      539     -9991     
+ Misses        8915      869     -8046     
+ Partials      1773      142     -1631     
Flag Coverage Δ
unittests 34.77% <ø> (-14.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Long file paths in the "Add and order .tfvars files" popover overflowed the row and broke the layout. Add min-w-0 to the flex containers and truncate the source path, with a Tooltip to reveal the full path on hover.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@RemiBonnet
RemiBonnet force-pushed the fix/tfvars-popover-truncate-long-path branch from 8f94f58 to 88a991e Compare August 14, 2026 10:10
@RemiBonnet
RemiBonnet merged commit ed829d0 into staging Aug 14, 2026
6 of 7 checks passed
@RemiBonnet
RemiBonnet deleted the fix/tfvars-popover-truncate-long-path branch August 14, 2026 10:15
@RemiBonnet

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 1.338.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants