clip: fix wrong-type format arguments (CodeQL high-severity)#68
Merged
Conversation
Two cpp/wrong-type-format-argument defects (high severity): - the vision_feature_layer/proj_spatial_offsets size-mismatch throw passed size_t values to %d and had no argument for its leading %s; use %zu and pass __func__. - the qwen-flamingo projector-block loop used size_t bid, passed to the %d in the TN_QF_* tensor-name formats; make bid int so the format type matches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the two
cpp/wrong-type-format-argumentdefects CodeQL flags as high-severity intools/mtmd/clip.cpp:vision_feature_layer.size() != proj_spatial_offsets.size()error throw passed twosize_tvalues to%dand had no argument for its leading%s(so the first size_t was formatted as the string). Now uses%zufor the sizes and passes__func__for%s.size_t bid, passed to the%din theTN_QF_*tensor-name format strings. Madebidanintso the format type matches (the tensor names are unchanged).Why
CodeQL reported these as new high-severity alerts on
prism, failing the CodeQL check. Both are genuine format/argument type mismatches (UB / garbage output), not false positives.Test
mtmdtarget builds clean.