Skip to content

Add BW1 Trades to API - #1696

Open
notblisy wants to merge 7 commits into
PokeAPI:masterfrom
notblisy:master
Open

notblisy wants to merge 7 commits into
PokeAPI:masterfrom
notblisy:master

Conversation

@notblisy

Copy link
Copy Markdown
Contributor

Add all BW1 Trades to the API. Referenced the bulbapedia page for this.

AI coding assistance disclosure

No AI was used to make this PR.

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

@jemarq04 jemarq04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution again! I commented a couple typos I found.

Would you also be able to update a new file we've added? Just to mention these are shiny-locked. The file is encounter_pokemon_details.csv.

123033,163
123034,199
123035,363
123036,18

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
123036,18

I don't think there's a season requirement on the Cottonee trade, right?

123030,361
123031,195
123032,230
123033,163

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
123033,163
123033,362

The condition should be trade-boldore, not trade-krabby for the Emolga

123036,18
123036,196
123037,230
123038,163

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
123038,163
123038,362

Same as above – trade-boldore, not trade-krabby

123038,163
123039,199
123040,363
123039,18

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
123039,18

Similar comment as before – I don't think the Rotom trade requires it to be summer in White?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
123039,18
123035,18
123040,18

Looks like the Munchlax trade does need it to be summer in both versions.

1664,5,Gare de Safrania
1665,9,Olivine City Gym
1665,5,Arène d'Oliville
1665,9,Nacrene City(Dyes House)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1665,9,Nacrene City(Dyes House)
1665,9,Nacrene City (Dye's House)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants