Add pokemon form trigger conditions#1578
Open
dyp1109 wants to merge 3 commits into
Open
Conversation
Naramsim
requested changes
Jun 30, 2026
Naramsim
left a comment
Naramsim
left a comment
Member
There was a problem hiding this comment.
Hi, can you merge the migrations into a single one?
Can you address the failing tests?
jemarq04
suggested changes
Jul 1, 2026
| 2231,peat-block,10,0,, | ||
| 2232,metal-alloy,10,0,, No newline at end of file | ||
| 2232,metal-alloy,10,0,, | ||
| 2559,clefablite,44,0,80, |
Member
There was a problem hiding this comment.
Why start at 2559 instead of 2233?
| @@ -0,0 +1,224 @@ | |||
| pokemon_form_id,form_method_id,item_id,ability_id,move_id | |||
Member
There was a problem hiding this comment.
Maybe some more descriptive names like trigger_item_id and so on?
| @@ -0,0 +1,7 @@ | |||
| id,identifier | |||
Member
There was a problem hiding this comment.
We should also add a pokemon_form_method_prose.csv file to match
| model = PokemonFormName | ||
| fields = ("name", "pokemon_name", "language") | ||
|
|
||
| class PokemonFormTriggerSerializer(serializers.ModelSerializer): |
Member
There was a problem hiding this comment.
I do like form trigger as the name rather than form method, but whatever you choose we should make it consistent between these classes and the file.
Contributor
Author
|
The new update addresses the comments to fix the ID and naming issues. Migrations is merged into single file and prose csv file is added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
Addressing issues #1549 by adding new form triggers fields in
/api/v2/pokemon-form/endpoints.Changes included:
PokemonFormMethodandPokemonFormConditionmodels to store how a form is activated,pokemon_form_methods.csvto define trigger types, andpokemon_form_conditions.csvto link forms to their trigger methods.items.csvAI coding assistance disclosure
I use AI assistant for formatting.
Contributor check list