Add gem quality for matching socket based on equipped item - #10022
Open
vaisest wants to merge 10 commits into
Open
Add gem quality for matching socket based on equipped item#10022vaisest wants to merge 10 commits into
vaisest wants to merge 10 commits into
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
3.29 added a mechanic where gems that are in the matching colour sockets adds +10% quality. This PR adds handling for that, and in general socket-related things which are actually relevant because of that change.
Steps taken to verify a working solution:
Currently this PR does NOT handle empty sockets at all. This is clearly problematic since the gems will not match the correct sockets if the gaps are missing, but solving this for sure requires changing the way socket groups are handled or saved, and so I think it's best done later in a separate PR. This PR intentionally makes no changes to the way gems are saved.
Link to a build that showcases this PR:
Nearly any character should work.
Dialla's: https://poe.ninja/poe1/builds/allflame?items=Dialla%27s+Malefaction
All 4 types of quality at once (ground slam group): https://poe.ninja/poe1/pob/9519e
Before screenshot:
After screenshot:
Path.space.of.space.Building_2026-08-02_17-07-30.mp4